Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in tracemalloc #121390

Closed
jbrobst opened this issue Jul 5, 2024 · 1 comment
Closed

Memory leak in tracemalloc #121390

jbrobst opened this issue Jul 5, 2024 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@jbrobst
Copy link
Contributor

jbrobst commented Jul 5, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

The tracemalloc_tracebacks hash table has traceback keys and NULL values, but its destructors do not reflect this -- key_destroy_func is NULL while value_destroy_func is raw_free. The leaked traceback keys can be seen with AddressSanitizer:

./configure --with-pydebug --with-address-sanitizer
make -j "$(nproc)"
./python -X tracemalloc -c 'print("hello there")'

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@jbrobst jbrobst added the type-bug An unexpected behavior, bug, or error label Jul 5, 2024
@jbrobst jbrobst mentioned this issue Jul 5, 2024
Merged
vstinner pushed a commit that referenced this issue Jul 5, 2024
@jbrobst
gh-121390: tracemalloc: Fix tracebacks memory leak (#121391)
db39bc4 
The tracemalloc_tracebacks hash table has traceback keys and NULL
values, but its destructors do not reflect this -- key_destroy_func is
NULL while value_destroy_func is raw_free. Swap these to free the
traceback keys instead.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 5, 2024
@jbrobst @miss-islington
pythongh-121390: tracemalloc: Fix tracebacks memory leak (pythonGH-12…
473f3f6 
…1391)

The tracemalloc_tracebacks hash table has traceback keys and NULL
values, but its destructors do not reflect this -- key_destroy_func is
NULL while value_destroy_func is raw_free. Swap these to free the
traceback keys instead.
(cherry picked from commit db39bc4)

Co-authored-by: Josh Brobst <jbrobst@proton.me>
@bedevere-app bedevere-app bot mentioned this issue Jul 5, 2024
Open
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 5, 2024
@jbrobst @miss-islington
pythongh-121390: tracemalloc: Fix tracebacks memory leak (pythonGH-12…
b59f27a 
…1391)

The tracemalloc_tracebacks hash table has traceback keys and NULL
values, but its destructors do not reflect this -- key_destroy_func is
NULL while value_destroy_func is raw_free. Swap these to free the
traceback keys instead.
(cherry picked from commit db39bc4)

Co-authored-by: Josh Brobst <jbrobst@proton.me>
@bedevere-app bedevere-app bot mentioned this issue Jul 5, 2024
Merged
@vstinner
Copy link
Member

vstinner commented Jul 5, 2024

Fixed by db39bc4.

@vstinner vstinner closed this as completed Jul 5, 2024
vstinner pushed a commit that referenced this issue Jul 5, 2024
@miss-islington @jbrobst
[3.12] gh-121390: tracemalloc: Fix tracebacks memory leak (GH-121391) (…
9e542f9 
…#121393)

gh-121390: tracemalloc: Fix tracebacks memory leak (GH-121391)

The tracemalloc_tracebacks hash table has traceback keys and NULL
values, but its destructors do not reflect this -- key_destroy_func is
NULL while value_destroy_func is raw_free. Swap these to free the
traceback keys instead.
(cherry picked from commit db39bc4)

Co-authored-by: Josh Brobst <jbrobst@proton.me>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@jbrobst @noahbkim
pythongh-121390: tracemalloc: Fix tracebacks memory leak (python#121391)
635ffd5 
The tracemalloc_tracebacks hash table has traceback keys and NULL
values, but its destructors do not reflect this -- key_destroy_func is
NULL while value_destroy_func is raw_free. Swap these to free the
traceback keys instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @jbrobst