urllib2 parse_http_list wrong return

[jimjjewett]

BPO	735248
Nosy	@birkenfeld, @birkenfeld

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2005-08-24.22:21:15.000>
created_at = <Date 2003-05-09.14:09:12.000>
labels = ['library']
title = 'urllib2 parse_http_list wrong return'
updated_at = <Date 2005-08-24.22:21:15.000>
user = 'https://bugs.python.org/jimjjewett'

bugs.python.org fields:

activity = <Date 2005-08-24.22:21:15.000>
actor = 'georg.brandl'
assignee = 'georg.brandl'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2003-05-09.14:09:12.000>
creator = 'jimjjewett'
dependencies = []
files = []
hgrepos = []
issue_num = 735248
keywords = []
message_count = 3.0
messages = ['15937', '15938', '15939']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'georg.brandl', 'jjlee', 'jimjjewett']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue735248'
versions = []

[jimjjewett]

parse_http_list should split a string on commas, unless
the commas are within a quoted-string. (It allows only
the "" quote, and not the single-quote, but this seems to
follow the RFC.)

If there are not quoted-strings, it repeats the first tokens
as part of subsequent tokens.

parse_http_list ('a,b') => ['a','a,b']
It should return ['a','b']

parse_http_list ('a,b,c') => ['a','a,b','a,b,c']
It should return ['a','b','c']

Patch: On (cvs version) line 882, when no quote is found
and inquote is false, reset the start position to after the
comma.

        if q == -1:
            if inquote:
                raise ValueError, "unbalanced quotes"
            else:
                list.append(s[start:i+c])
                i = i + c + 1
                start = i            #New line
                continue

[jjlee]

Logged In: YES
user_id=261020

This function doesn't deal with quoting of characters inside
quoted-strings, either. In particular, it doesn't deal with \", \\,
and \, (see RFC 2616, section 2.2, quoted-pair).

[birkenfeld]

Logged In: YES
user_id=1188172

Fixed the algorithm in Lib/urllib2.py r1.86, 1.77.2.3
Added testcase in Lib/test/test_urllib2.py r1.22, 1.19.2.1