Cookie.py produces invalid code

[sdahlbac]

BPO	1108948
Nosy	@birkenfeld, @birkenfeld
Files	Cookie.patch.py: new version of js_output function

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2005-06-26.21:03:38.000>
created_at = <Date 2005-01-25.09:04:05.000>
labels = ['extension-modules']
title = 'Cookie.py produces invalid code'
updated_at = <Date 2005-06-26.21:03:38.000>
user = 'https://bugs.python.org/sdahlbac'

bugs.python.org fields:

activity = <Date 2005-06-26.21:03:38.000>
actor = 'georg.brandl'
assignee = 'georg.brandl'
closed = True
closed_date = None
closer = None
components = ['Extension Modules']
creation = <Date 2005-01-25.09:04:05.000>
creator = 'sdahlbac'
dependencies = []
files = ['1564']
hgrepos = []
issue_num = 1108948
keywords = []
message_count = 2.0
messages = ['24029', '24030']
nosy_count = 3.0
nosy_names = ['georg.brandl', 'georg.brandl', 'sdahlbac']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1108948'
versions = ['Python 2.3']

[sdahlbac]

The code in js_output in the Morsel class in Cookie.py
produces invalid code, the scripting language should be
specified by mimetype and not by language as per
http://www.w3.org/TR/html401/interact/scripts.html

also, the javascript line is missing an ending semi-colon

attached a "patch" (new version of the function in
question)

present at least in 2.3 but still broken in current cvs

A related matter: the existing documentation is poor,
only after a substantial amount of code reading and
googling I found out how to set attributes such as
expires and path.

[birkenfeld]

Logged In: YES
user_id=1188172

Thanks for the report, fixed as of Lib/Cookie.py r1.18.

I do not backport this as some code might rely on the
language HTML attribute.