Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_subprocess is far too slow #41590

Closed
mwhudson opened this issue Feb 17, 2005 · 10 comments
Closed

test_subprocess is far too slow #41590

mwhudson opened this issue Feb 17, 2005 · 10 comments
Labels
stdlib Python modules in the Lib dir

Comments

@mwhudson
Copy link

BPO 1124637
Nosy @mwhudson, @tim-one, @birkenfeld

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2005-03-04.10:17:14.000>
created_at = <Date 2005-02-17.11:10:13.000>
labels = ['library']
title = 'test_subprocess is far too slow'
updated_at = <Date 2005-03-04.10:17:14.000>
user = 'https://github.com/mwhudson'

bugs.python.org fields:

activity = <Date 2005-03-04.10:17:14.000>
actor = 'mwh'
assignee = 'astrand'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2005-02-17.11:10:13.000>
creator = 'mwh'
dependencies = []
files = []
hgrepos = []
issue_num = 1124637
keywords = []
message_count = 10.0
messages = ['24321', '24322', '24323', '24324', '24325', '24326', '24327', '24328', '24329', '24330']
nosy_count = 5.0
nosy_names = ['mwh', 'tim.peters', 'anthonybaxter', 'georg.brandl', 'astrand']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1124637'
versions = ['Python 2.4']

@mwhudson
Copy link
Author

test_subprocess takes multiple minutes. I'm pretty
sure it's "test_no_leaking". It should either be sped
up or only tested when some -u argument is passed to
regrtest.

@mwhudson mwhudson added the stdlib Python modules in the Lib dir label Feb 17, 2005
@mwhudson mwhudson added the stdlib Python modules in the Lib dir label Feb 17, 2005
@astrand
Copy link
Mannequin

astrand mannequin commented Feb 17, 2005

Logged In: YES
user_id=344921

Tell me a bit about your type of OS and hardware. On my
machine (P4 2.66 GHz with Linux), the test takes 28 seconds.

@mwhudson
Copy link
Author

Logged In: YES
user_id=6656

Bog standard linux pc -- p3 933, 384 megs of ram.

"$ time ./python ../Lib/test/regrtest.py test_subprocess"
reports 2 minutes 7. This is a debug build, a release build
might be quicker. A run of the entire test suite takes a
hair over nine minutes, so 20-odd % of the time seems to be
test_subprocess.

It also takes ages on my old-ish ibook (600 Mhz G3, also 384
megs of ram), but that's at home and I can't time it.

@anthonybaxter
Copy link
Mannequin

anthonybaxter mannequin commented Feb 17, 2005

Logged In: YES
user_id=29957

I'm with mwh. This test should be enabled with an option -
I'd noticed that test_subprocess took a long time, but
hadn't bothered to track it down.

Before releases (and at other times) I always try to make
sure that I run 'make testall', but for day-to-day use, this
is too slow.

@tim-one
Copy link
Member

tim-one commented Feb 17, 2005

Logged In: YES
user_id=31435

Peculiar -- test_subprocess takes about 8 seconds on my
WinXP box release build, about 10 seconds debug build, and
Windows is notorious for slow process creation. That's a
zippy 3.4 GHz P4, but clock rate alone can't account for such
a large speed difference.

@astrand
Copy link
Mannequin

astrand mannequin commented Feb 17, 2005

Logged In: YES
user_id=344921

tim_one: test_subprocess only creates 65 processes on
Windows, compared to 1026 for UNIX.

@astrand
Copy link
Mannequin

astrand mannequin commented Mar 3, 2005

Logged In: YES
user_id=344921

Fixed in HEAD revisions:
regrtest.py: 1.166
1.19

Fixed in 2.4 revisions:
regrtest.py: 1.165.2.1
test_subprocess.py: 1.15.2.2

@birkenfeld
Copy link
Member

Logged In: YES
user_id=1188172

Shouldn't it be closed then?

@astrand
Copy link
Mannequin

astrand mannequin commented Mar 3, 2005

Logged In: YES
user_id=344921

Forgot to close.

@mwhudson
Copy link
Author

mwhudson commented Mar 4, 2005

Logged In: YES
user_id=6656

Thank you!

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Development

No branches or pull requests

3 participants