poorly named variable in urllib2.py

[roysmith]

BPO	1175848
Nosy	@birkenfeld, @birkenfeld

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2005-06-26.22:01:57.000>
created_at = <Date 2005-04-03.15:26:51.000>
labels = ['library']
title = 'poorly named variable in urllib2.py'
updated_at = <Date 2005-06-26.22:01:57.000>
user = 'https://bugs.python.org/roysmith'

bugs.python.org fields:

activity = <Date 2005-06-26.22:01:57.000>
actor = 'georg.brandl'
assignee = 'georg.brandl'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2005-04-03.15:26:51.000>
creator = 'roysmith'
dependencies = []
files = []
hgrepos = []
issue_num = 1175848
keywords = []
message_count = 3.0
messages = ['24872', '24873', '24874']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'georg.brandl', 'jjlee', 'roysmith']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1175848'
versions = ['Python 2.3']

[roysmith]

This is kind of trivial, but in urllib2.OpenerDirector.__init__, the local
variable "server_version" is poorly named. The name makes it
sound like it's the version of the HTTP (or whatever) server we're
talking to. How about client_version or library_version or
module_version?

[jjlee]

Logged In: YES
user_id=261020

My, you're picky. ;-)

Yes, that does seem a poor name, +1 on changing it to
client_version.

[birkenfeld]

Logged In: YES
user_id=1188172

Fixed as of Lib/urllib2.py r1.82.