Zipfile fix create_system information

[hendriktt]

BPO	1229511
Nosy	@birkenfeld, @ronaldoussoren
Files	zipfile_create_system.patch: patch for create_system information

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2006-04-01.03:20:58.000>
created_at = <Date 2005-06-29.07:47:31.000>
labels = []
title = 'Zipfile fix create_system information'
updated_at = <Date 2006-04-01.03:20:58.000>
user = 'https://bugs.python.org/hendriktt'

bugs.python.org fields:

activity = <Date 2006-04-01.03:20:58.000>
actor = 'sf-robot'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['None']
creation = <Date 2005-06-29.07:47:31.000>
creator = 'hendriktt'
dependencies = []
files = ['6715']
hgrepos = []
issue_num = 1229511
keywords = ['patch']
message_count = 4.0
messages = ['48533', '48534', '48535', '48536']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'sf-robot', 'ronaldoussoren', 'hendriktt']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1229511'
versions = []

[hendriktt]

this patches corrects the create_system value for
created zipfiles with the zipfile module, which is
platform dependent (better: filesystem dependent).
It fixes the following bug: if a zipfile is created
with Python on Unix and the files have executable flags
the file rights are correctly saved into the zipfile.
But when extracting the file with unzip (from Info-zip)
the filerights (executable flags) are not reassigned
correctly. This is due to the wrong create_system flag.

The patch is not the 100% correct way to do it, but it
is better as the situation now (completly ignore the
system and always set create_system to 0).

The right way to fix this would be to set the
create_system flag dependent on the platform and the
filesystem but I do not know how to do this.

[ronaldoussoren]

Logged In: YES
user_id=580910

Could you check if the trunk is acceptable to you, and if so close this patch?

Patch 1412872 also sets create_system to another value on unix systems and
was applied at 05 feb 2006.

[birkenfeld]

Logged In: YES
user_id=849994

Waiting for input from OP.

[sf-robot]

Logged In: YES
user_id=1312539

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).