New with semantics

[gvanrossum]

BPO	1445739
Nosy	@gvanrossum
Files	new_with.patch: first rough patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2006-03-15.07:59:28.000>
created_at = <Date 2006-03-08.15:50:55.000>
labels = ['interpreter-core']
title = 'New with semantics'
updated_at = <Date 2006-03-15.07:59:28.000>
user = 'https://github.com/gvanrossum'

bugs.python.org fields:

activity = <Date 2006-03-15.07:59:28.000>
actor = 'nnorwitz'
assignee = 'gvanrossum'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2006-03-08.15:50:55.000>
creator = 'gvanrossum'
dependencies = []
files = ['7059']
hgrepos = []
issue_num = 1445739
keywords = ['patch']
message_count = 2.0
messages = ['49689', '49690']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'nnorwitz']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1445739'
versions = ['Python 2.5']

[gvanrossum]

Here's a patch that implements the new with statement
semantics: if __exit__ got passed an exception, it is
only swallowed when __exit__ returns *true*. So it is
no longer necessary for __exit__ handlers to re-raise
the exception.

This is a bit rough still -- existing unit tests have
been adjusted, but there should be additional unit
tests for the new functionality. Also the re-raise
code in various __exit__ handlers coded in the previous
patch could be removed (note that re-raising doesn't do
any harm -- it's just not necessary).

[nnorwitz]

Logged In: YES
user_id=33168

Guido checked this in a few days ago AFAIK, so closing.