Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny patch to stop make spam #43479

Closed
catlee mannequin opened this issue Jun 9, 2006 · 3 comments
Closed

Tiny patch to stop make spam #43479

catlee mannequin opened this issue Jun 9, 2006 · 3 comments
Assignees
Labels
build The build process and cross-build

Comments

@catlee
Copy link
Mannequin

catlee mannequin commented Jun 9, 2006

BPO 1503717
Nosy @akuchling, @birkenfeld, @catlee
Files
  • Makefile.patch: patch against r46798 to stop make spam
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/akuchling'
    closed_at = <Date 2006-10-27.18:15:29.000>
    created_at = <Date 2006-06-09.20:42:23.000>
    labels = ['build']
    title = 'Tiny patch to stop make spam'
    updated_at = <Date 2006-10-27.18:15:29.000>
    user = 'https://github.com/catlee'

    bugs.python.org fields:

    activity = <Date 2006-10-27.18:15:29.000>
    actor = 'akuchling'
    assignee = 'akuchling'
    closed = True
    closed_date = None
    closer = None
    components = ['Build']
    creation = <Date 2006-06-09.20:42:23.000>
    creator = 'catlee'
    dependencies = []
    files = ['7321']
    hgrepos = []
    issue_num = 1503717
    keywords = ['patch']
    message_count = 3.0
    messages = ['50449', '50450', '50451']
    nosy_count = 3.0
    nosy_names = ['akuchling', 'georg.brandl', 'catlee']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1503717'
    versions = []

    @catlee
    Copy link
    Mannequin Author

    catlee mannequin commented Jun 9, 2006

    It's always bothered me that python's Makefile outputs:
    case $MAKEFLAGS in \
    *-s*) CC='gcc -pthread' LDSHARED='gcc -pthread
    -shared' OPT='-DNDEBUG -g -O3 -Wall
    -Wstrict-prototypes' ./python -E ./setup.py -q build;; \
    *) CC='gcc -pthread' LDSHARED='gcc -pthread
    -shared' OPT='-DNDEBUG -g -O3 -Wall
    -Wstrict-prototypes' ./python -E ./setup.py build;; \
    esac

    Maybe it does this for a good reason I don't know about :)

    In case there isn't, here's a one-line patch to fix it.

    @catlee catlee mannequin closed this as completed Jun 9, 2006
    @catlee catlee mannequin assigned akuchling Jun 9, 2006
    @catlee catlee mannequin added the build The build process and cross-build label Jun 9, 2006
    @catlee catlee mannequin closed this as completed Jun 9, 2006
    @catlee catlee mannequin assigned akuchling Jun 9, 2006
    @catlee catlee mannequin added the build The build process and cross-build label Jun 9, 2006
    @birkenfeld
    Copy link
    Member

    Logged In: YES
    user_id=849994

    I'm very much for this!

    @akuchling
    Copy link
    Member

    Logged In: YES
    user_id=11375

    Seems like a reasonable change; applied to the trunk in
    rev.52484. Thanks!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants