Backward incompatibility in logging.py

[klaas]

BPO	1569622
Nosy	@birkenfeld, @vsajip

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-01-08.18:30:12.000>
created_at = <Date 2006-10-02.23:10:28.000>
labels = ['library']
title = 'Backward incompatibility in logging.py '
updated_at = <Date 2007-01-08.18:30:12.000>
user = 'https://bugs.python.org/klaas'

bugs.python.org fields:

activity = <Date 2007-01-08.18:30:12.000>
actor = 'klaas'
assignee = 'nnorwitz'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2006-10-02.23:10:28.000>
creator = 'klaas'
dependencies = []
files = []
hgrepos = []
issue_num = 1569622
keywords = []
message_count = 9.0
messages = ['30128', '30129', '30130', '30131', '30132', '30133', '30134', '30135', '30136']
nosy_count = 4.0
nosy_names = ['nnorwitz', 'georg.brandl', 'vinay.sajip', 'klaas']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1569622'
versions = ['Python 2.5']

[klaas]

LogRecord.__init__ changed in a backward incompatible
way in python 2.5 (added one parameter).

There is no mention of this breakage in the release
notes, nor has the documentation of the module been
updated (http://docs.python.org/lib/node424.html)

[birkenfeld]

Logged In: YES
user_id=849994

I don't see why adding one parameter is backwards
incompatible, but it's true that the docs must be updated.
Assigning to Vinay.

[klaas]

Logged In: YES
user_id=1611720

It is incompatible as code written for 2.4 will break in
2.5, and vice-versa (this is a required parameter, not an
optional parameter, and the change could have been made in a
backward-compatible way).

You're right that the documentation fix is the important thing.

[vsajip]

Logged In: YES
user_id=308438

Documentation now updated in CVS. Also changed the added
"func" parameter to have a default value of None.

Sorry for the inconvenience caused.

[klaas]

This fix should be back-ported to 2.5 maint:

r52100,52101,52102

perhaps also r52555,52556?

[vsajip]

Done. I'm not sure what you're getting at with those revision numbers - trunk and branches/release25-maint are now up to date; if you think other branches need to be updated, please name those branches explicitly.

[klaas]

Sorry - I was just trying to to see if the fix was backported, and I only saw the trunk checkins on python-checkins

[vsajip]

No need to be sorry, you were absolutely right to re-open the issue for backports - I had not originally checked in the backport. What I meant in my last mail was that I have now checked in the backport, but wasn't sure about the specific revisions you were referring to.

Thanks for the reminder about release25-maint.

[klaas]

Ah... the revisions were simply the fix revisions (the last two were not directly related to this issue, but one was a documentation bug, and the other was a minor performance edit, so I thought those might also be backport candidates).