SocketServer allow_reuse_address checked in constructor

[parente]

BPO	1595742
Nosy	@birkenfeld

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-03-10.14:44:22.000>
created_at = <Date 2006-11-13.16:54:22.000>
labels = ['library']
title = 'SocketServer allow_reuse_address checked in constructor'
updated_at = <Date 2007-03-10.14:44:22.000>
user = 'https://bugs.python.org/parente'

bugs.python.org fields:

activity = <Date 2007-03-10.14:44:22.000>
actor = 'collinwinter'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2006-11-13.16:54:22.000>
creator = 'parente'
dependencies = []
files = []
hgrepos = []
issue_num = 1595742
keywords = []
message_count = 6.0
messages = ['30534', '30535', '30536', '30537', '30538', '30539']
nosy_count = 3.0
nosy_names = ['georg.brandl', 'collinwinter', 'parente']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1595742'
versions = ['Python 2.6']

[parente]

Python 2.4.3 (#1, Oct 1 2006, 18:00:19)
[GCC 4.1.1 20060928 (Red Hat 4.1.1-28)] on linux2

The documentation in the SocketServer class indicates
that the allow_reuse_address flag may be set on a
SocketServer subclass *or instance.* However, the flag
is read in a call to the server_bind() from the
constructor of the server object. Therefore, setting
the flag on a created instance has no effect. This is
problematic when trying to set the flag on
SimpleXMLRPCServer instances, for instance, which are
often not subclassed.

This flag should probably become one of the keyword
arguments in the constructor of a SocketServer object.

[birkenfeld]

Would you want to work on a patch for this?

[parente]

Will do.

[parente]

The SimpleXMLRPCServer class in SVN HEAD now has allow_reuse_address set to True by default. This mimics the implementation of the BaseHTTPServer class which also has it set to True. Therefore, this patch should probably not concentrate on just making allow_reuse_address flag accessible on instances via __init__. Instead, the patch should probably be for TCPServer and specify whether server_bind and server_activate are called automatically or not by the constructor. The default behavior will remain the same as it is now. Specifying False on this flag will allow a developer to set the various variables on a TCPServer server instance before invoking bind/activate manually.

[parente]

Submitted as patch bpo-1599845 in patch tracker.

[collinwinter]

Fixed by applying patch bpo-1599845 as r54262. Thanks for your bug report!