Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-logging compatability with Zope. #44334

Closed
shookway mannequin opened this issue Dec 13, 2006 · 6 comments
Closed

python-logging compatability with Zope. #44334

shookway mannequin opened this issue Dec 13, 2006 · 6 comments
Assignees
Labels
stdlib Python modules in the Lib dir

Comments

@shookway
Copy link
Mannequin

shookway mannequin commented Dec 13, 2006

BPO 1614460
Nosy @birkenfeld, @vsajip
Files
  • python2.4-logging.patch: Patch replaces _handlers dict and list with an ordered dict.
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/vsajip'
    closed_at = <Date 2007-02-16.18:27:51.000>
    created_at = <Date 2006-12-13.03:02:21.000>
    labels = ['library']
    title = 'python-logging compatability with Zope.'
    updated_at = <Date 2007-02-16.18:27:51.000>
    user = 'https://bugs.python.org/shookway'

    bugs.python.org fields:

    activity = <Date 2007-02-16.18:27:51.000>
    actor = 'vinay.sajip'
    assignee = 'vinay.sajip'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2006-12-13.03:02:21.000>
    creator = 'shookway'
    dependencies = []
    files = ['2253']
    hgrepos = []
    issue_num = 1614460
    keywords = []
    message_count = 6.0
    messages = ['30798', '30799', '30800', '30801', '30802', '30803']
    nosy_count = 4.0
    nosy_names = ['georg.brandl', 'vinay.sajip', 'sf-robot', 'shookway']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1614460'
    versions = ['Python 2.4']

    @shookway
    Copy link
    Mannequin Author

    shookway mannequin commented Dec 13, 2006

    I'm using Zope2.8.x and python2.4.

    On shutdown removing the handlers causes a KeyError because the new _handlersList is not correctly updated and thus has a now non-existant handler in it.

    This double list/dict thing is a little cumbersome. I'm not sure either why it's a dict but i have replaced it with an OrderedDict so that old 2.3 logging behaviour works without modification.

    See the included patch.

    @shookway shookway mannequin closed this as completed Dec 13, 2006
    @shookway shookway mannequin assigned vsajip Dec 13, 2006
    @shookway shookway mannequin added the stdlib Python modules in the Lib dir label Dec 13, 2006
    @shookway shookway mannequin closed this as completed Dec 13, 2006
    @shookway shookway mannequin assigned vsajip Dec 13, 2006
    @shookway shookway mannequin added the stdlib Python modules in the Lib dir label Dec 13, 2006
    @birkenfeld
    Copy link
    Member

    I believe this was fixed in 2.5, but I could be mistaken.

    @vsajip
    Copy link
    Member

    vsajip commented Dec 15, 2006

    Yes, a fix was applied a while ago.

    @sf-robot
    Copy link
    Mannequin

    sf-robot mannequin commented Dec 30, 2006

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

    @shookway
    Copy link
    Mannequin Author

    shookway mannequin commented Feb 11, 2007

    "fixed in 2.5" -- that is the problem, why was this fix not rolled back to python2.4? I submit this patch for those of us out there still using 2.4 and likely to be using it for a while to come.

    Can we have it fixed in 2.4 please.

    @vsajip
    Copy link
    Member

    vsajip commented Feb 16, 2007

    The change was backported to the release24-maint branch some time ago - sorry for not making it clear.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants