Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary stderr patch #45693

Closed
tiran opened this issue Oct 28, 2007 · 12 comments
Closed

Preliminary stderr patch #45693

tiran opened this issue Oct 28, 2007 · 12 comments
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Oct 28, 2007

BPO 1352
Nosy @gvanrossum, @loewis, @birkenfeld, @tiran
Files
  • py3k_preliminary_stderr.patch
  • py3k_preliminary_stderr2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
    closed_at = <Date 2007-10-30.18:35:10.612>
    created_at = <Date 2007-10-28.13:51:14.742>
    labels = ['interpreter-core', 'type-feature']
    title = 'Preliminary stderr patch'
    updated_at = <Date 2007-11-02.21:14:25.982>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2007-11-02.21:14:25.982>
    actor = 'loewis'
    assignee = 'gvanrossum'
    closed = True
    closed_date = <Date 2007-10-30.18:35:10.612>
    closer = 'gvanrossum'
    components = ['Interpreter Core']
    creation = <Date 2007-10-28.13:51:14.742>
    creator = 'christian.heimes'
    dependencies = []
    files = ['8644', '8648']
    hgrepos = []
    issue_num = 1352
    keywords = []
    message_count = 12.0
    messages = ['56880', '56899', '56943', '56955', '56974', '56977', '57019', '57026', '57062', '57064', '57065', '57066']
    nosy_count = 4.0
    nosy_names = ['gvanrossum', 'loewis', 'georg.brandl', 'christian.heimes']
    pr_nums = []
    priority = 'high'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue1352'
    versions = ['Python 3.0']

    @tiran
    Copy link
    Member Author

    tiran commented Oct 28, 2007

    Here is another patch related to stdio from me. It creates and sets up a
    very dumb and easy stderr writer until the new io infrastructure is
    initialized. It makes debugging problems in the init phase much easier.

    @tiran tiran added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement labels Oct 28, 2007
    @tiran
    Copy link
    Member Author

    tiran commented Oct 29, 2007

    Improved patch

    @gvanrossum gvanrossum self-assigned this Oct 29, 2007
    @gvanrossum
    Copy link
    Member

    Good idea.

    Are there any places where PyBytes or PyString are written to stderr?
    Or can you get away with just supporting PyUnicode?

    It's "dumb", not "dump".

    I wouldn't explicitly remove the old stderr printer -- it will be
    deleted automatically by the PyDict_SetItemString() call in
    PySys_SetObject(). That way you'll still have it when the
    PyFile_FromFd() call fails...

    This patch doesn't commute with your 'closefd' patch...

    @tiran
    Copy link
    Member Author

    tiran commented Oct 30, 2007

    Guido van Rossum wrote:

    Are there any places where PyBytes or PyString are written to stderr?
    Or can you get away with just supporting PyUnicode?

    I could have simple copied the write method from _fileio.c and letting
    the argument parser do its job instead of fighting with the API for 20
    minutes. :

    It's "dumb", not "dump".

    I need an IDE with a context aware spell checker :]

    I wouldn't explicitly remove the old stderr printer -- it will be
    deleted automatically by the PyDict_SetItemString() call in
    PySys_SetObject(). That way you'll still have it when the
    PyFile_FromFd() call fails...

    I didn't know that. I'll keep it in place.

    @gvanrossum
    Copy link
    Member

    I've checked in the patch you added to bpo-1329, with one mod: where
    you wrote "int fd : 1;" I removed the ": 1" since a field width of one
    bit makes no sense here.

    @tiran
    Copy link
    Member Author

    tiran commented Oct 30, 2007

    Guido van Rossum wrote:

    I've checked in the patch you added to bpo-1329, with one mod: where
    you wrote "int fd : 1;" I removed the ": 1" since a field width of one
    bit makes no sense here.

    Can you close http://bugs.python.org/issue1771260, too?

    Christian

    @birkenfeld
    Copy link
    Member

    You should be able to close it yourself now :)

    @gvanrossum
    Copy link
    Member

    Georg, could you explain somewhere in the tracker docs linked from the
    tracker side bar what the options are? I looked into giving Christian
    more tracker privileges before, but I didn't know what to type in the
    Roles box. IOW I don't know what the allowable roles are, what they
    mean, or where to find a list that describes them.

    On 11/1/07, Georg Brandl <report@bugs.python.org> wrote:

    Georg Brandl added the comment:

    You should be able to close it yourself now :)

    @birkenfeld
    Copy link
    Member

    I've submitted a new bug in the meta tracker.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 2, 2007

    I just created

    http://wiki.python.org/moin/TrackerAccessControl

    which specifies all permissions in the tracker in detail.

    @gvanrossum
    Copy link
    Member

    http://wiki.python.org/moin/TrackerAccessControl

    which specifies all permissions in the tracker in detail.

    Is it so that Anonymous < User < Developer < Coordinator? If so, the
    role field could just be a dropdown instead of a list of roles...

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 2, 2007

    Guido van Rossum added the comment:

    > http://wiki.python.org/moin/TrackerAccessControl
    >
    > which specifies all permissions in the tracker in detail.

    Is it so that Anonymous < User < Developer < Coordinator?

    Not in roundup per se, no. It is so in this installation.

    If so, the role field could just be a
    dropdown instead of a list of roles...

    I believe a lot of these permissions are redundant. People
    holding the Developer role typically also hold the User
    role. It might be possible to drop the User role from the
    developers, and the User and Developer roles from the Coordinators,
    without loss of permissions - but there is a chance that doing
    so would break things in case some permission was forgotten.

    Regards,
    Martin

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants