SimpleXMLRPCDispatcher.__init__ is not python2.4-backward-compatible

[doko42]

BPO	2703
Nosy	@warsaw, @birkenfeld, @doko42, @amauryfa
Files	dispatcher.diff: patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/doko42'
closed_at = <Date 2010-10-27.07:09:55.250>
created_at = <Date 2008-04-27.09:56:34.117>
labels = ['type-bug', 'library']
title = 'SimpleXMLRPCDispatcher.__init__ is not python2.4-backward-compatible'
updated_at = <Date 2010-10-27.07:09:55.168>
user = 'https://github.com/doko42'

bugs.python.org fields:

activity = <Date 2010-10-27.07:09:55.168>
actor = 'georg.brandl'
assignee = 'doko'
closed = True
closed_date = <Date 2010-10-27.07:09:55.250>
closer = 'georg.brandl'
components = ['Library (Lib)']
creation = <Date 2008-04-27.09:56:34.117>
creator = 'doko'
dependencies = []
files = ['10120']
hgrepos = []
issue_num = 2703
keywords = ['patch']
message_count = 4.0
messages = ['65883', '65913', '85544', '119676']
nosy_count = 5.0
nosy_names = ['barry', 'georg.brandl', 'doko', 'amaury.forgeotdarc', 'schmir']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2703'
versions = ['Python 2.6', 'Python 2.7']

[doko42]

[forwarded from http://bugs.debian.org/470645]

"SimpleXMLRPCDispatcher.__init__ used to take a single argument
(self) in python2.4 and now it takes three. The two new arguments
need to get default values or else this breaks backwards
compatibility badly."

while SimpleXMLRPCDispatcher is not described as part of the interface,
it is mentioned in the docs. The fix seems to be easy. Ok for trunk and
the branch?

[amauryfa]

The patch is OK, but I'm still -0.

The doc string says: "There should never be any reason to instantiate
this class directly." I don't see how this could "break backwards
compatibility badly".

[warsaw]

I'm -0, but if the tests pass and Matthias wants to commit this to 2.6
and 2.7, it's fine with me.

[birkenfeld]

Seems to have been changed in 2.6 and 2.7 already.