Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about tuple parameters #47310

Closed
benjaminp opened this issue Jun 8, 2008 · 6 comments
Closed

Warn about tuple parameters #47310

benjaminp opened this issue Jun 8, 2008 · 6 comments
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@benjaminp
Copy link
Contributor

BPO 3060
Nosy @birkenfeld, @benjaminp
Files
  • tuple_parameters_warn.patch
  • tuple_parameters_warn2.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/birkenfeld'
    closed_at = <Date 2008-06-08.23:11:06.886>
    created_at = <Date 2008-06-08.01:45:53.270>
    labels = ['interpreter-core', 'type-bug']
    title = 'Warn about tuple parameters'
    updated_at = <Date 2008-06-08.23:11:06.885>
    user = 'https://github.com/benjaminp'

    bugs.python.org fields:

    activity = <Date 2008-06-08.23:11:06.885>
    actor = 'benjamin.peterson'
    assignee = 'georg.brandl'
    closed = True
    closed_date = <Date 2008-06-08.23:11:06.886>
    closer = 'benjamin.peterson'
    components = ['Interpreter Core']
    creation = <Date 2008-06-08.01:45:53.270>
    creator = 'benjamin.peterson'
    dependencies = []
    files = ['10549', '10553']
    hgrepos = []
    issue_num = 3060
    keywords = ['patch']
    message_count = 6.0
    messages = ['67820', '67823', '67825', '67842', '67845', '67850']
    nosy_count = 2.0
    nosy_names = ['georg.brandl', 'benjamin.peterson']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue3060'
    versions = ['Python 2.6']

    @benjaminp
    Copy link
    Contributor Author

    This patch adds Py3k warnings to nested tuple parameters.

    @benjaminp benjaminp added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Jun 8, 2008
    @birkenfeld
    Copy link
    Member

    Why not warn in the AST, like for the other syntax-related changes?
    The relevant location is ast_for_arguments, line 680 in current SVN.

    @birkenfeld
    Copy link
    Member

    Also a test is missing.

    @benjaminp
    Copy link
    Contributor Author

    Why not warn in the AST, like for the other syntax-related changes?

    because I was reading through symtable.c at the time. :)

    Anyway, here's a better patch.

    @birkenfeld
    Copy link
    Member

    Replace "upacking" with "unpacking" and you can commit it :)

    @benjaminp
    Copy link
    Contributor Author

    Done with r64045.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants