test_ssl.py doesn't properly test ssl integration with asyncore

[giampaolo]

BPO	3899
Nosy	@josiahcarlson, @pitrou, @giampaolo
Files	test_ssl.patch unnamed

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-09-04.00:35:25.811>
created_at = <Date 2008-09-18.13:35:49.930>
labels = ['type-bug', 'library']
title = "test_ssl.py doesn't properly test ssl integration with asyncore"
updated_at = <Date 2010-09-04.00:35:25.809>
user = 'https://github.com/giampaolo'

bugs.python.org fields:

activity = <Date 2010-09-04.00:35:25.809>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2010-09-04.00:35:25.811>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2008-09-18.13:35:49.930>
creator = 'giampaolo.rodola'
dependencies = []
files = ['11518', '11528']
hgrepos = []
issue_num = 3899
keywords = ['patch']
message_count = 5.0
messages = ['73382', '73398', '73417', '73441', '115551']
nosy_count = 5.0
nosy_names = ['josiahcarlson', 'janssen', 'pitrou', 'giampaolo.rodola', 'josiah.carlson']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3899'
versions = ['Python 2.6', 'Python 3.1']

[giampaolo]

The AsyncoreEchoServer class in test_ssl.py doesn't actually test a real
integration with asyncore since the do_handshake_on_connect flag is set
to True and hence temporarily blocks the asyncore polling loop as long
as the ssl handshake finishes.
The patch in attachment subclasses some asyncore internals so that a
non-blocking ssl handshake takes place.

Tested under Windows XP SP3, Python 2.6rc1.

[janssen]

The server wasn't meant to be non-blocking. The non-blocking test is
performed when the client (which is non-blocking) connects to it.

[josiahcarlson]

Being able to test the async features of both sides of the SSL
connection is a good thing.

Also, the subclass provides a useful example for users who want to use
asyncore and ssl servers without blocking on an incoming connection.

[janssen]

Sure, no argument. I was just making clear what was going on.

Bill

On Thu, Sep 18, 2008 at 7:33 PM, Josiah Carlson <report@bugs.python.org>wrote:

Josiah Carlson <josiahcarlson@users.sourceforge.net> added the comment:

Being able to test the async features of both sides of the SSL
connection is a good thing.

Also, the subclass provides a useful example for users who want to use
asyncore and ssl servers without blocking on an incoming connection.

---

Python tracker <report@bugs.python.org>
<http://bugs.python.org/issue3899\>

---

[pitrou]

This has been integrated long ago.