Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for urllib.request.HTTPRedirectHandler.redirect_request missing "hdrs" paramether #49144

Closed
mroman mannequin opened this issue Jan 9, 2009 · 3 comments
Closed
Assignees
Labels
docs Documentation in the Doc dir easy type-feature A feature request or enhancement

Comments

@mroman
Copy link
Mannequin

mroman mannequin commented Jan 9, 2009

BPO 4894
Nosy @birkenfeld, @orsenthil, @devdanzin
Files
  • redirect_request_rst.diff: Adds "newurl" to docs, mention URI header in http_error_301
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/birkenfeld'
    closed_at = <Date 2009-02-13.10:43:37.617>
    created_at = <Date 2009-01-09.13:58:35.252>
    labels = ['easy', 'type-feature', 'docs']
    title = 'Docs for urllib.request.HTTPRedirectHandler.redirect_request missing "hdrs" paramether'
    updated_at = <Date 2009-02-13.10:43:37.616>
    user = 'https://bugs.python.org/mroman'

    bugs.python.org fields:

    activity = <Date 2009-02-13.10:43:37.616>
    actor = 'georg.brandl'
    assignee = 'georg.brandl'
    closed = True
    closed_date = <Date 2009-02-13.10:43:37.617>
    closer = 'georg.brandl'
    components = ['Documentation']
    creation = <Date 2009-01-09.13:58:35.252>
    creator = 'mroman'
    dependencies = []
    files = ['12984']
    hgrepos = []
    issue_num = 4894
    keywords = ['patch', 'easy']
    message_count = 3.0
    messages = ['79468', '81417', '81901']
    nosy_count = 5.0
    nosy_names = ['georg.brandl', 'quiver', 'orsenthil', 'ajaksu2', 'mroman']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'patch review'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue4894'
    versions = ['Python 2.6', 'Python 3.0', 'Python 3.1', 'Python 2.7']

    @mroman
    Copy link
    Mannequin Author

    mroman mannequin commented Jan 9, 2009

    documentaion doesn't include parameter in
    urllib.request.HTTPRedirectHandler.redirect_request

    http://docs.python.org/3.0/library/urllib.request.html#urllib.request.HT
    TPRedirectHandler.redirect_request

    says:
    HTTPRedirectHandler.redirect_request(req, fp, code, msg, hdrs)

    while code says:
        def redirect_request(self, req, fp, code, msg, headers, newurl):

    @mroman mroman mannequin assigned birkenfeld Jan 9, 2009
    @mroman mroman mannequin added the docs Documentation in the Doc dir label Jan 9, 2009
    @devdanzin
    Copy link
    Mannequin

    devdanzin mannequin commented Feb 8, 2009

    This patch adds the "newurl" parameter to signature of redirect_request
    (important, IMHO) and mentions it in the doc (less important). It also
    describes the behavior of http_error_30* in more detail, perhaps too much?

    @devdanzin devdanzin mannequin added the easy label Feb 12, 2009
    @devdanzin devdanzin mannequin changed the title documentaion doesn't include parameter in urllib.request.HTTPRedirectHandler.redirect_request Docs for urllib.request.HTTPRedirectHandler.redirect_request missing "hdrs" paramether Feb 12, 2009
    @devdanzin devdanzin mannequin added the type-feature A feature request or enhancement label Feb 12, 2009
    @birkenfeld
    Copy link
    Member

    Applied in r69570, r69571.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir easy type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant