Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the term "delete" within the documentation for os.remove() and os.rmdir() #50926

Closed
mcow mannequin opened this issue Aug 10, 2009 · 6 comments
Closed

Place the term "delete" within the documentation for os.remove() and os.rmdir() #50926

mcow mannequin opened this issue Aug 10, 2009 · 6 comments
Assignees
Labels
docs Documentation in the Doc dir

Comments

@mcow
Copy link
Mannequin

mcow mannequin commented Aug 10, 2009

BPO 6677
Nosy @birkenfeld, @terryjreedy

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2009-08-24.17:25:10.310>
created_at = <Date 2009-08-10.17:09:51.757>
labels = ['docs']
title = 'Place the term "delete" within the documentation for os.remove() and os.rmdir()'
updated_at = <Date 2009-08-24.18:04:00.945>
user = 'https://bugs.python.org/mcow'

bugs.python.org fields:

activity = <Date 2009-08-24.18:04:00.945>
actor = 'mcow'
assignee = 'georg.brandl'
closed = True
closed_date = <Date 2009-08-24.17:25:10.310>
closer = 'georg.brandl'
components = ['Documentation']
creation = <Date 2009-08-10.17:09:51.757>
creator = 'mcow'
dependencies = []
files = []
hgrepos = []
issue_num = 6677
keywords = []
message_count = 6.0
messages = ['91456', '91586', '91930', '91932', '91933', '91934']
nosy_count = 3.0
nosy_names = ['georg.brandl', 'terry.reedy', 'mcow']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue6677'
versions = ['Python 2.6', 'Python 3.1']

@mcow
Copy link
Mannequin Author

mcow mannequin commented Aug 10, 2009

"Remove" and "unlink" are not the most widely-known verbs that come
to mind when thinking about deleting objects from the filesystem.
A recent Google search for "python delete file" led to the documentation
for the 'os' module:
http://docs.python.org/library/os.html
but searching within that page for "delet" completely misses
os.remove(), os.unlink(), and os.rmdir().

Suggest simply expanding the first sentence of os.remove()'s paragraph to:
Remove the file /path/ (delete the file).

Similarly for os.rmdir():
Remove the directory /path/ (delete the directory).

Also regarding os.rmdir(), it would be nice to add a mention here of
this information from os.walk(): "rmdir() doesn’t allow deleting a
directory before the directory is empty."

The URL above is for the 2.6 version (chapter 16.1.4); also seen in the
3.1 documentation (15.1.5); presumably it's also in the development
versions. Patching backwards as far as feasible would be appreciated.

@mcow mcow mannequin assigned birkenfeld Aug 10, 2009
@mcow mcow mannequin added the docs Documentation in the Doc dir label Aug 10, 2009
@terryjreedy
Copy link
Member

If a change is make, 'remove (delete)' would be sufficient.

@birkenfeld
Copy link
Member

Fixed in r74548.

@mcow
Copy link
Mannequin Author

mcow mannequin commented Aug 24, 2009

Thanks, but the bug requested a similar change for "rmdir" as well.

Is it not possible to backport the change to the 2.x branch?

@birkenfeld
Copy link
Member

True. Fixed in r74550.

The changes will be ported to all maintained branches soon.

@mcow
Copy link
Mannequin Author

mcow mannequin commented Aug 24, 2009

Very good. Thank you, Georg.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

No branches or pull requests

2 participants