New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pybench #51278
Comments
The attached patch contains suggested fixes to pybench.py:
The last one is important. Traditionally, the focus would be on Looking at the minimum and average of the sum is a much stabler Another thing that I found when working with this, is that using |
Kristján Valur Jónsson wrote: Thanks for the patch. Here's a quick review (a bit terse, but
I'm not sure why you added this: the systimes.py module All you have to do is use this command line option to
Thanks for spotting this one.
I'm assuming that "gross" = test time + overhead. Is that right ? I like the idea, but not the implementation :-) Don't like my own
I agree. For the minimum times, the minimum over all tests
The idea behind the calibration is to hide away the overhead This is due to the fact that the number of iteration rounds OTOH, timers have not gotten a lot more accurate. As a result, the measurements of pybench on todays machines The only way to resolve this is to adjust all tests - something |
Hello Marc-Andre.
About the calibration: I ran into problems where I was tuning the The calibration technique is not a bad idea, but it would be helpful, So, how can I improve this? |
Here is an updated patch with the superfluous timing function removed. I'm also considering adding a '--quiet' flag that causes it to only emit |
And here is the actual patch. |
Kristján Valur Jónsson wrote:
The reporting methods are a complete mess (not your patch, my code). Something that would need to change is the .stat() patch: why In any case, please don't invest too much time into this. I'm going
Could be useful, yes. |
Ok, thanks for the info. |
Fixed the bug with "timer = timer" in trunk in revision 75293 |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: