-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspect.isabstract to return boolean values only #51318
Comments
Currently, inspect.isabstract() may return an integer like 1048576 Although technically correct, no other isXXX function behaves that way; The attached patch makes inspect.isabstract() return a boolean value |
The patch works, as this is what is implicitly happening anyway if you use Gabriel, would you like to write tests for this function? |
Tests added. |
I changed the patch so it does not introduce new dependencies and fails |
I don't think we should test the actual type returned (bool); that |
That's fine with me. Looks like nobody wants to check it in anyways. |
Applied in r75433. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: