Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid expires date in cookiejar #53072

Closed
tzulberti mannequin opened this issue May 26, 2010 · 2 comments
Closed

Invalid expires date in cookiejar #53072

tzulberti mannequin opened this issue May 26, 2010 · 2 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@tzulberti
Copy link
Mannequin

tzulberti mannequin commented May 26, 2010

BPO 8826
Nosy @birkenfeld

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-08-01.09:06:50.445>
created_at = <Date 2010-05-26.18:01:57.723>
labels = ['type-bug']
title = 'Invalid expires date in cookiejar'
updated_at = <Date 2010-08-01.09:06:50.381>
user = 'https://bugs.python.org/tzulberti'

bugs.python.org fields:

activity = <Date 2010-08-01.09:06:50.381>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = <Date 2010-08-01.09:06:50.445>
closer = 'georg.brandl'
components = ['None']
creation = <Date 2010-05-26.18:01:57.723>
creator = 'tzulberti'
dependencies = []
files = []
hgrepos = []
issue_num = 8826
keywords = []
message_count = 2.0
messages = ['106557', '112295']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'tzulberti']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue8826'
versions = ['Python 2.6']

@tzulberti
Copy link
Mannequin Author

tzulberti mannequin commented May 26, 2010

This happens when creating a SimpleCookie from an string. The value in the cookie is: "expires=Fri, 31-Dec-2010 23:59:59 GMT"

But in the cookiejar, the value if only "Fri,".

As far as I know, the error is in the regular expresion _LegalCharsPatt, that doesn't allows whitespaces. The format of the expires date was taken from the wikipedia: http://en.wikipedia.org/wiki/HTTP_cookie#Cookie_attributes

@tzulberti tzulberti mannequin added the type-bug An unexpected behavior, bug, or error label May 26, 2010
@birkenfeld
Copy link
Member

Thanks, fixed in r83398.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant