tarfile: broken hardlink handling and testcase.

[jsbronder]

BPO	8833
Nosy	@gustaebel, @jsbronder
Files	python-2.7-tarfile-hardlinks.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gustaebel'
closed_at = <Date 2010-06-03.10:18:09.621>
created_at = <Date 2010-05-27.16:07:07.922>
labels = ['type-bug', 'library']
title = 'tarfile:  broken hardlink handling and testcase.'
updated_at = <Date 2010-06-03.10:18:09.619>
user = 'https://github.com/jsbronder'

bugs.python.org fields:

activity = <Date 2010-06-03.10:18:09.619>
actor = 'lars.gustaebel'
assignee = 'lars.gustaebel'
closed = True
closed_date = <Date 2010-06-03.10:18:09.621>
closer = 'lars.gustaebel'
components = ['Library (Lib)']
creation = <Date 2010-05-27.16:07:07.922>
creator = 'jsbronder'
dependencies = []
files = ['17474']
hgrepos = []
issue_num = 8833
keywords = ['patch']
message_count = 2.0
messages = ['106612', '106936']
nosy_count = 2.0
nosy_names = ['lars.gustaebel', 'jsbronder']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue8833'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']

[jsbronder]

When adding hardlinks to an archive, tarfile does not set the size
of each additional link to zero as specified by the tar format [1].

In addition, the current test case hardlinks is also broken.
Instead of testing that the size of a hardlink to a non-empty file
is 0, it tests that the size to a empty file is zero, which cannot
fail.

A patch against current svn trunk is attached and was tested with
'python -m test.regrtest -v test_tarfile'

1. http://www.gnu.org/software/tar/manual/tar.html#SEC170

[gustaebel]

Thank you very much for this valuable report. Fixed in r81663-81666.