Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py contains needless references to built-in _weakref module #54057

Closed
Arfrever mannequin opened this issue Sep 13, 2010 · 2 comments
Closed

setup.py contains needless references to built-in _weakref module #54057

Arfrever mannequin opened this issue Sep 13, 2010 · 2 comments
Assignees
Labels
build The build process and cross-build

Comments

@Arfrever
Copy link
Mannequin

Arfrever mannequin commented Sep 13, 2010

BPO 9848
Nosy @brettcannon, @birkenfeld

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2010-09-14.19:42:10.808>
created_at = <Date 2010-09-13.19:31:46.249>
labels = ['build']
title = 'setup.py contains needless references to built-in _weakref module'
updated_at = <Date 2010-09-14.19:42:10.800>
user = 'https://bugs.python.org/Arfrever'

bugs.python.org fields:

activity = <Date 2010-09-14.19:42:10.800>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2010-09-14.19:42:10.808>
closer = 'brett.cannon'
components = ['Build']
creation = <Date 2010-09-13.19:31:46.249>
creator = 'Arfrever'
dependencies = []
files = []
hgrepos = []
issue_num = 9848
keywords = []
message_count = 2.0
messages = ['116343', '116418']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'georg.brandl', 'Arfrever']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue9848'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

@Arfrever
Copy link
Mannequin Author

Arfrever mannequin commented Sep 13, 2010

_weakref module is a built-in module in Python 3 since r58602, but references to _weakref module in setup.py haven't been removed. They can be removed in py3k and 3.1 branches.

setup.py in 2.7 branch (since r84233) contains unused, commented out reference to _weakref module, which also can be removed.

@Arfrever Arfrever mannequin added the build The build process and cross-build label Sep 13, 2010
@brettcannon
Copy link
Member

Fixed in r84819 for 3.2. No point in backporting since it doesn't hurt anything.

Thanks for the report!

@brettcannon brettcannon self-assigned this Sep 14, 2010
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build
Projects
None yet
Development

No branches or pull requests

1 participant