test_sys triggers a fatal python error when run under coverage.py

[brettcannon]

BPO	10985
Nosy	@brettcannon, @birkenfeld
Files	issue10985.diff: Make test_sys.test_recursionlimit_recovery CPython-only & sys.gettrace() is false

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2011-01-23.23:06:35.348>
created_at = <Date 2011-01-23.00:18:05.991>
labels = ['type-crash', 'release-blocker']
title = 'test_sys triggers a fatal python error when run under coverage.py'
updated_at = <Date 2011-01-23.23:06:35.347>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2011-01-23.23:06:35.347>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2011-01-23.23:06:35.348>
closer = 'brett.cannon'
components = []
creation = <Date 2011-01-23.00:18:05.991>
creator = 'brett.cannon'
dependencies = []
files = ['20496']
hgrepos = []
issue_num = 10985
keywords = ['patch']
message_count = 6.0
messages = ['126865', '126866', '126867', '126900', '126905', '126907']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'georg.brandl']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue10985'
versions = ['Python 3.2']

[brettcannon]

If you run test_sys under coverage.py with ./python.exe -m coverage run --pylib [Lib/test/regrtest.py](https://github.com/python/cpython/blob/main/Lib/test/regrtest.py) test_sys you get::

Fatal Python error: Cannot recover from stack overflow

Have not taken the time to try to figure out exactly what code is triggering the recursion, but coverage.py is being used w/o its extension coverage support. Could be caused by coverage.py, but I'm a bit surprised that it's a fatal error instead of a recursion limit exception.

[brettcannon]

Ran the test under verbose mode at Antoine's suggestion; test triggering the failure is test_recursionlimit_recovery

[brettcannon]

The comment on the test says its brittle and sensitive to nothing mucking around with recursion depth, so the test probably need a unittest.skipIf check for a trace function.

[brettcannon]

I have a patch for this which makes it a CPython-only test along with being conditional if a trace function is set. Making it a release blocker to see if Georg will let me commit it.

[brettcannon]

Georg cleared the commit; just waiting for a test run with coverage.py to finish before committing.

[brettcannon]

r88153 w/ a review by Georg Brandl