Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X installer build script for 3.2 can no longer build with system Python on OS X 10.5 #55263

Closed
ned-deily opened this issue Jan 29, 2011 · 5 comments
Assignees
Labels
build The build process and cross-build OS-mac

Comments

@ned-deily
Copy link
Member

BPO 11054
Nosy @birkenfeld, @rhettinger, @ronaldoussoren, @ned-deily
Files
  • issue_synch_installer_py3k.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ned-deily'
    closed_at = <Date 2011-01-30.01:51:27.439>
    created_at = <Date 2011-01-29.03:47:07.351>
    labels = ['OS-mac', 'build']
    title = 'OS X installer build script for 3.2 can no longer build with system Python on OS X 10.5'
    updated_at = <Date 2011-01-30.01:51:27.438>
    user = 'https://github.com/ned-deily'

    bugs.python.org fields:

    activity = <Date 2011-01-30.01:51:27.438>
    actor = 'ned.deily'
    assignee = 'ned.deily'
    closed = True
    closed_date = <Date 2011-01-30.01:51:27.439>
    closer = 'ned.deily'
    components = ['Build', 'macOS']
    creation = <Date 2011-01-29.03:47:07.351>
    creator = 'ned.deily'
    dependencies = []
    files = ['20595']
    hgrepos = []
    issue_num = 11054
    keywords = ['patch']
    message_count = 5.0
    messages = ['127377', '127380', '127385', '127464', '127505']
    nosy_count = 4.0
    nosy_names = ['georg.brandl', 'rhettinger', 'ronaldoussoren', 'ned.deily']
    pr_nums = []
    priority = None
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue11054'
    versions = ['Python 2.7', 'Python 3.2']

    @ned-deily
    Copy link
    Member Author

    During the 3.2rc1 release cycle, it was discovered that it was no longer possible to build the 32-bit installer on OS X 10.5 as customary with the system Python 2.5 due to an inadvertent 2.6 feature ("with") added to the OS X installer build script. This unnecessarily complicates the installer build process and violates past attempts to keep the installer script buildable with the system Python and compatible across current Python 2.x and 3.x releases. The attached patch to the installer script removes the "with", properly guards a new Python 3 only build step, and updates the comments and README file. The patched build script has been tested on both OS X 10.5 and 10.6. This patch should be included in 3.2rc2.

    @ned-deily ned-deily self-assigned this Jan 29, 2011
    @ned-deily ned-deily added build The build process and cross-build OS-mac labels Jan 29, 2011
    @rhettinger
    Copy link
    Contributor

    +1 for reversion.

    @birkenfeld
    Copy link
    Member

    Looks okay to me (and any bugs are likely to become apparent when the installers are built...)

    @ned-deily
    Copy link
    Member Author

    Committed in r88235 for 3.2rc2 with release manager approval.
    Pending 2.7 backport.

    @ned-deily
    Copy link
    Member Author

    Merged to 2.7 in r88248 (for 2.7.2).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build OS-mac
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants