Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RLock support the context manager protocol but this is not documented #57259

Closed
bitdancer opened this issue Sep 27, 2011 · 6 comments
Closed
Labels
docs Documentation in the Doc dir

Comments

@bitdancer
Copy link
Member

BPO 13050
Nosy @birkenfeld, @rhettinger, @bitdancer
Files
  • issue13050.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-04-14.10:31:29.711>
    created_at = <Date 2011-09-27.19:02:06.704>
    labels = ['docs']
    title = 'RLock support the context manager protocol but this is not documented'
    updated_at = <Date 2013-04-14.10:31:29.709>
    user = 'https://github.com/bitdancer'

    bugs.python.org fields:

    activity = <Date 2013-04-14.10:31:29.709>
    actor = 'georg.brandl'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2013-04-14.10:31:29.711>
    closer = 'georg.brandl'
    components = ['Documentation']
    creation = <Date 2011-09-27.19:02:06.704>
    creator = 'r.david.murray'
    dependencies = []
    files = ['24167']
    hgrepos = []
    issue_num = 13050
    keywords = ['patch']
    message_count = 6.0
    messages = ['145260', '145268', '150824', '150828', '159535', '186905']
    nosy_count = 7.0
    nosy_names = ['georg.brandl', 'rhettinger', 'r.david.murray', 'docs@python', 'bbrazil', 'godfryd', 'zacherates']
    pr_nums = []
    priority = 'normal'
    resolution = 'out of date'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue13050'
    versions = ['Python 3.3']

    @bitdancer bitdancer added the docs Documentation in the Doc dir label Sep 27, 2011
    @bbrazil
    Copy link
    Mannequin

    bbrazil mannequin commented Oct 9, 2011

    @bitdancer
    Copy link
    Member Author

    Hmm. But what I did was look up the RLock section of the manual to answer the question "does this support the context manager protocol", and the answer appeared to be no. In a reference manual I would expect all the important features of an object to be described in that object's documentation, or linked to therefrom.

    @zacherates
    Copy link
    Mannequin

    zacherates mannequin commented Jan 7, 2012

    Here is a patch that adds an note about using Locks, RLocks, Conditions, and Semaphores as context managers to each of their descriptions as well as a link to the "Using locks, conditions, and semaphores in the with statement" section.

    @rhettinger
    Copy link
    Contributor

    This edit looks reasonable.

    @godfryd
    Copy link
    Mannequin

    godfryd mannequin commented Apr 28, 2012

    It looks that it is already documented by 76228:2040842626ba changeset.
    The bug can be closed.

    @birkenfeld
    Copy link
    Member

    Thanks, closing.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants