Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update howto/cporting.rst so it talks about Python 3 instead of 3.0 #57295

Closed
larryhastings opened this issue Oct 1, 2011 · 17 comments
Closed
Assignees
Labels
docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@larryhastings
Copy link
Contributor

BPO 13086
Nosy @loewis, @birkenfeld, @terryjreedy, @larryhastings, @ezio-melotti, @merwok
Files
  • larry.cporting.to.python.3.r1.diff
  • larry.cporting.to.python.3.r2.diff
  • larry.cporting.to.python.3.r3.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/larryhastings'
    closed_at = <Date 2012-02-29.00:32:16.836>
    created_at = <Date 2011-10-01.10:57:41.709>
    labels = ['type-feature', 'docs']
    title = 'Update howto/cporting.rst so it talks about Python 3 instead of 3.0'
    updated_at = <Date 2012-02-29.09:03:10.626>
    user = 'https://github.com/larryhastings'

    bugs.python.org fields:

    activity = <Date 2012-02-29.09:03:10.626>
    actor = 'ezio.melotti'
    assignee = 'larry'
    closed = True
    closed_date = <Date 2012-02-29.00:32:16.836>
    closer = 'larry'
    components = ['Documentation']
    creation = <Date 2011-10-01.10:57:41.709>
    creator = 'larry'
    dependencies = []
    files = ['23357', '24653', '24654']
    hgrepos = []
    issue_num = 13086
    keywords = ['patch']
    message_count = 17.0
    messages = ['144721', '144726', '144727', '144733', '145153', '145231', '145267', '145269', '154397', '154401', '154410', '154442', '154581', '154582', '154583', '154585', '154588']
    nosy_count = 7.0
    nosy_names = ['loewis', 'georg.brandl', 'terry.reedy', 'larry', 'ezio.melotti', 'eric.araujo', 'python-dev']
    pr_nums = []
    priority = 'low'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue13086'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

    @larryhastings
    Copy link
    Contributor Author

    The title of howto/cporting.rst is "Porting Extension Modules To 3.0". It then talks about 3.0 in a whole bunch of places. Considering that we're working on 3.3, and considering that 3.0 is end-of-lifed (not even meriting a branch in hg), wouldn't it be better for the document to talk about "3.x"? It already talks about "2.x" in several places, so it's not like this would confuse the reader.

    Alternatively, we could remove the ".0" (and maybe the ".x"s) so the document talks about porting from "Python 2" to "Python 3".

    I'd be happy to make the patch / check in the change.

    @larryhastings larryhastings self-assigned this Oct 1, 2011
    @larryhastings larryhastings added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Oct 1, 2011
    @larryhastings
    Copy link
    Contributor Author

    Why shouldn't I check this in to the 2.7 / 3.1 branches?

    @birkenfeld
    Copy link
    Member

    3.1 because it won't have any effect; it's in security-fix mode.

    For 2.7 go ahead.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Oct 1, 2011

    I like "Python 2" more than "2.x".

    @terryjreedy
    Copy link
    Member

    Yes, 'to Python 3'. Patch welcome. I would make it up to date as of 3.2. For 3.3, the Unicode api will change (grow) but that has not been finalized yet.

    @merwok
    Copy link
    Member

    merwok commented Oct 9, 2011

    +1 ;)

    @merwok merwok changed the title Update howto/cporting.rst so it talks about 3.x instead of 3.0 Update howto/cporting.rst so it talks about Python 3 instead of 3.0 Oct 9, 2011
    @larryhastings
    Copy link
    Contributor Author

    Attached is my first revision patch. I did some other editing for
    clarity / 80 columns, though I can back those out from this patch (and put in another) if that's best.

    Patch is against the 2.7 branch; once this goes in I'll port all my recent cporting.rst changes to 3.2 and trunk.

    @ezio-melotti
    Copy link
    Member

    Attached is my first revision patch.

    LGTM

    I did some other editing for clarity / 80 columns, though I can back
    those out from this patch (and put in another) if that's best.

    That's fine with me, and while you are at it, you could fix this too when you commit:
    + the many Python level changes made leaving Python 2's API intact
    s/Python level/Python-level/

    Patch is against the 2.7 branch; once this goes in I'll port all my
    recent cporting.rst changes to 3.2 and trunk.

    Remember to convert things like :cmacro: to :c:macro: when you port it.

    @larryhastings
    Copy link
    Contributor Author

    Gah! This one fell through the cracks.

    Attached is an updated patch with Ezio's "Python-level" fix, and a little more paragraph tidying. (Apart from that one ^ dash, the only changes
    between r1 and r2 are eols.)

    Unless I hear otherwise, I'll check this in to 2.7 on Tuesday or so. Then I'll manually edit the 3.2 docs to match, and once that goes in I'll forward-merge into trunk.

    @ezio-melotti
    Copy link
    Member

    Note that the 2.7 docs now use a recent Sphinx too, so :c:macro: should work on all the 3 branches (so you don't have to use :cmacro: on 2.7 and :c:macro: on 3.x).

    @larryhastings
    Copy link
    Contributor Author

    Whoops--I hadn't updated my repo since last year, and someone had already changed to :c:macro:, :c:func:, and :c:type:. When will I learn!

    Attached is a new diff with those changes, against revision @4c6662090870 (on the 2.7 branch). Also, while I was in there, I made some minor edits to the start of the paragraph about "long/int Unification". I think it's a slight improvement.

    @merwok
    Copy link
    Member

    merwok commented Feb 27, 2012

    +can simply switch to :c:type:`Capsule`. If you need to support Python 3.0,
    +or versions of Python earlier than 2.7,
    +you'll have to support both CObjects and Capsules.

    We pretend that Python 3.0 never existed, or was a beta. Python 3.1 is the first supported 3.x release. Thus I think you can delete that mention.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 28, 2012

    New changeset eb88cc90cc56 by Larry Hastings in branch '2.7':
    Issue bpo-13086: Update howto/cporting.rst to discuss "Python 3" instead of "3.0".
    http://hg.python.org/cpython/rev/eb88cc90cc56

    @larryhastings
    Copy link
    Contributor Author

    @eric.araujo: I talked to Brett about it. We don't pretend that Python 3.0 never existed; we tell people it's unsupported and unsuitable for production use. At his suggestion I added a statement to that effect, and left the rest the same.

    I'll now manually incorporate this into the 3.2 branch, then forward-port to trunk.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 29, 2012

    New changeset 28849d00a41e by Larry Hastings in branch '3.2':
    Propagate changes for issues bpo-13053 and bpo-13086 from 2.7 to 3.2. (Doc only.)
    http://hg.python.org/cpython/rev/28849d00a41e

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 29, 2012

    New changeset c316e8a4a5e2 by Larry Hastings in branch 'default':
    Merge: Propagate changes for issues bpo-13053 and bpo-13086 from 2.7 to 3.2.
    http://hg.python.org/cpython/rev/c316e8a4a5e2

    @larryhastings
    Copy link
    Contributor Author

    Now checked in to 2.7, 3.2, and default. Thanks everyone!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    5 participants