The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly

[elibendersky]

BPO	14349
Nosy	@birkenfeld, @ncoghlan, @pitrou
Files	issue14349.1.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/pitrou'
closed_at = <Date 2012-03-24.16:54:09.259>
created_at = <Date 2012-03-17.15:08:05.875>
labels = ['type-bug', 'docs']
title = "The documentation of 'dis' doesn't describe MAKE_FUNCTION correctly"
updated_at = <Date 2012-03-24.16:54:09.258>
user = 'https://bugs.python.org/elibendersky'

bugs.python.org fields:

activity = <Date 2012-03-24.16:54:09.258>
actor = 'eli.bendersky'
assignee = 'pitrou'
closed = True
closed_date = <Date 2012-03-24.16:54:09.259>
closer = 'eli.bendersky'
components = ['Documentation']
creation = <Date 2012-03-17.15:08:05.875>
creator = 'eli.bendersky'
dependencies = []
files = ['25002']
hgrepos = []
issue_num = 14349
keywords = ['patch']
message_count = 4.0
messages = ['156161', '156649', '156692', '156707']
nosy_count = 6.0
nosy_names = ['georg.brandl', 'ncoghlan', 'pitrou', 'eli.bendersky', 'docs@python', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14349'
versions = ['Python 3.3']

[elibendersky]

The documentation of the MAKE_FUNCTION opcode in 'dis' says:

"Pushes a new function object on the stack. TOS is the code associated with the function. "

Which doesn't appear to be true. In Python/ceval.c:

[...]
        TARGET_WITH_IMPL(MAKE_CLOSURE, _make_function)
        TARGET(MAKE_FUNCTION)
        _make_function:
        {
            int posdefaults = oparg & 0xff;
            int kwdefaults = (oparg>>8) & 0xff;
            int num_annotations = (oparg >> 16) & 0x7fff;

            w = POP(); /* qualname */
            v = POP(); /* code object */
            x = PyFunction_NewWithQualName(v, f->f_globals, w);
[...]

[elibendersky]

Patch attached.

[birkenfeld]

Looks good to me.

[python-dev]

New changeset 242d3f8e8c50 by Eli Bendersky in branch 'default':
Issue bpo-14349: Fix the doc of the MAKE_FUNCTION opcode in Doc/library/dis.rst to
http://hg.python.org/cpython/rev/242d3f8e8c50