Memleak in import.c load_source_module()

[cassou]

BPO	14761
Nosy	@malemburg, @tim-one, @brettcannon, @ncoghlan, @pitrou, @benjaminp
Files	fix_load_source_module_leak.patch: Patch that fixes a memory leak in load_source_module() from import.c

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-05-09.11:31:36.189>
created_at = <Date 2012-05-09.08:45:54.556>
labels = ['interpreter-core', 'performance']
title = 'Memleak in import.c load_source_module()'
updated_at = <Date 2012-05-09.11:31:36.188>
user = 'https://bugs.python.org/cassou'

bugs.python.org fields:

activity = <Date 2012-05-09.11:31:36.188>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2012-05-09.11:31:36.189>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2012-05-09.08:45:54.556>
creator = 'cassou'
dependencies = []
files = ['25507']
hgrepos = []
issue_num = 14761
keywords = ['patch']
message_count = 6.0
messages = ['160262', '160264', '160265', '160271', '160272', '160274']
nosy_count = 8.0
nosy_names = ['lemburg', 'tim.peters', 'brett.cannon', 'ncoghlan', 'pitrou', 'benjamin.peterson', 'python-dev', 'cassou']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue14761'
versions = ['Python 2.7', 'Python 3.2']

[cassou]

In load_source_module() function from import.c, it looks like Py_DECREF is not called where it should be. Please find attached a patch that fixes the leak.

This bug has been found using Coccinelle (http://coccinelle.lip6.fr/) using a semantic patch (similar to https://gist.github.com/2634899).

[pitrou]

Is it 2.7-only?

[cassou]

@pitrou I just checked Python-2.7.3 and the tip of the mercurial repository. It's not in the latter at least.

[python-dev]

New changeset a775fc27f469 by Antoine Pitrou in branch '2.7':
Issue bpo-14761: Fix potential leak on an error case in the import machinery.
http://hg.python.org/cpython/rev/a775fc27f469

[python-dev]

New changeset 9de4d85e4197 by Antoine Pitrou in branch '3.2':
Issue bpo-14761: Fix potential leak on an error case in the import machinery.
http://hg.python.org/cpython/rev/9de4d85e4197

New changeset 840cb46d0395 by Antoine Pitrou in branch 'default':
Null merge for issue bpo-14761.
http://hg.python.org/cpython/rev/840cb46d0395

[pitrou]

Fixed, thank you!