Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear C code under PyImport_ExecCodeModuleObject() #59374

Closed
brettcannon opened this issue Jun 24, 2012 · 4 comments
Closed

Clear C code under PyImport_ExecCodeModuleObject() #59374

brettcannon opened this issue Jun 24, 2012 · 4 comments
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker

Comments

@brettcannon
Copy link
Member

BPO 15169
Nosy @loewis, @brettcannon

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2012-07-13.17:58:30.622>
created_at = <Date 2012-06-24.19:59:15.595>
labels = ['interpreter-core', 'release-blocker']
title = 'Clear C code under PyImport_ExecCodeModuleObject()'
updated_at = <Date 2012-07-13.17:58:30.621>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2012-07-13.17:58:30.621>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2012-07-13.17:58:30.622>
closer = 'brett.cannon'
components = ['Interpreter Core']
creation = <Date 2012-06-24.19:59:15.595>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 15169
keywords = []
message_count = 4.0
messages = ['163834', '163836', '164019', '165393']
nosy_count = 3.0
nosy_names = ['loewis', 'brett.cannon', 'python-dev']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'needs patch'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue15169'
versions = ['Python 3.3']

@brettcannon
Copy link
Member Author

import.c:PyImport_ExecCodeModuleObject() is holding on to a ton of C code thanks to get_sourcefile(). Should have PyImport_ExecCodeModuleWithPathnames() use get_sourcefile() only. And then get_sourcefile() should get re-implemented in Python code.

@brettcannon brettcannon added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jun 24, 2012
@loewis
Copy link
Mannequin

loewis mannequin commented Jun 24, 2012

I propose to defer this to 3.4.

@brettcannon
Copy link
Member Author

The problem of deferring to 3.4 is that it will lock in semantics which are honestly weird and not desirable for PyImport_ExecCodeModuleObject() which is new in 3.3.

@python-dev
Copy link
Mannequin

python-dev mannequin commented Jul 13, 2012

New changeset 9e164b404983 by Brett Cannon in branch 'default':
Issues bpo-15169, bpo-14599: Make PyImport_ExecCodeModuleWithPathnames() use
http://hg.python.org/cpython/rev/9e164b404983

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker
Projects
None yet
Development

No branches or pull requests

1 participant