Crash (constructed) in _PySequence_BytesToCharpArray()

[skrah]

BPO	15732
Nosy	@loewis, @skrah
Files	bytes_to_charp_array.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-08-20.09:21:34.418>
created_at = <Date 2012-08-20.07:43:20.307>
labels = ['interpreter-core', 'type-crash']
title = 'Crash (constructed) in _PySequence_BytesToCharpArray()'
updated_at = <Date 2012-08-20.09:21:34.351>
user = 'https://github.com/skrah'

bugs.python.org fields:

activity = <Date 2012-08-20.09:21:34.351>
actor = 'skrah'
assignee = 'none'
closed = True
closed_date = <Date 2012-08-20.09:21:34.418>
closer = 'skrah'
components = ['Interpreter Core']
creation = <Date 2012-08-20.07:43:20.307>
creator = 'skrah'
dependencies = []
files = ['26919']
hgrepos = []
issue_num = 15732
keywords = ['patch']
message_count = 4.0
messages = ['168633', '168634', '168637', '168638']
nosy_count = 3.0
nosy_names = ['loewis', 'skrah', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue15732'
versions = ['Python 3.2', 'Python 3.3']

[skrah]

Coverity found an unchecked return value in _PySequence_BytesToCharpArray().
Patch attached.

A demonstration:

import _posixsubprocess
class Z(object):
    def __len__(self):
        return 1

_posixsubprocess.fork_exec(1,Z(),3,[1, 2],5,6,7,8,9,10,11,12,13,14,15,16,17)

[loewis]

LGTM. Please apply to all affected branches.

[python-dev]

New changeset cfddcf964ff0 by Stefan Krah in branch '3.2':
Issue bpo-15732: Fix (constructed) crash in _PySequence_BytesToCharpArray().
http://hg.python.org/cpython/rev/cfddcf964ff0

[skrah]

Thanks for reviewing!