New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup a few minor things #61075
Comments
Here is a set of patches which clean a few minor things: add spaces after if/while/return/etc, remove spaces after class/function name, remove redundant parens after if/while/return/etc. One set contains only space changes, another set contains parens changes. |
For me none of these parens help while reading the code (but this is quite subjective). I not object if only a part of these changes will be applied. Review the patches and point what changes should be applied and what changes should not. |
How about innecessary code churn? |
I elaborate: bpo-15580. An example of many. |
Here is another recent comment from Georg on this topic: "And please don't commit cosmetic/"cleanup" changes to bugfix branches in the future." |
I'm -1 on this, however parts of the patches could be extracted and applied on individual modules in the 'default' branch only. This could be done by the modules' maintainers if they think it's OK. Note that while it's generally not OK doing this kind of refactoring on the code in maintenance branches, it's usually acceptable doing so for the documentation. |
Agreed. Maintainers of asynchat, tkinter.tix, optparse and difflib must pay attention to this. |
Ok for asyncore/asynchat in 3.4 branch. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: