Docs of subprocess.CREATE_NEW_CONSOLE are wrong

[Bluehorn]

BPO	16921
Nosy	@tjguk, @briancurtin, @asvetlov, @Bluehorn
Files	create_new_console.diff: Suggested documentation update doc.diff: Remove mention of CREATE_NEW_CONSOLE for shell=True

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tjguk'
closed_at = <Date 2013-07-31.15:11:10.831>
created_at = <Date 2013-01-10.17:42:20.418>
labels = ['OS-windows']
title = 'Docs of subprocess.CREATE_NEW_CONSOLE are wrong'
updated_at = <Date 2013-07-31.15:11:10.830>
user = 'https://github.com/Bluehorn'

bugs.python.org fields:

activity = <Date 2013-07-31.15:11:10.830>
actor = 'tim.golden'
assignee = 'tim.golden'
closed = True
closed_date = <Date 2013-07-31.15:11:10.831>
closer = 'tim.golden'
components = ['Windows']
creation = <Date 2013-01-10.17:42:20.418>
creator = 'torsten'
dependencies = []
files = ['28674', '28688']
hgrepos = []
issue_num = 16921
keywords = ['patch']
message_count = 5.0
messages = ['179578', '179660', '179661', '179662', '179678']
nosy_count = 5.0
nosy_names = ['tim.golden', 'brian.curtin', 'asvetlov', 'torsten', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue16921'
versions = ['Python 3.5']

[Bluehorn]

The documentation of CREATE_NEW_CONSOLE at http://docs.python.org/3/library/subprocess.html#subprocess.CREATE_NEW_CONSOLE states:

This flag is always set when Popen is created with shell=True.

This does not fit the code which does

if (_subprocess.GetVersion() >= 0x80000000 or os.path.basename(comspec).lower() == "command.com"):
    # Win9x, or using command.com on NT. We need to
    creationflags |= _subprocess.CREATE_NEW_CONSOLE

So the statement is only true on very old versions on Windows. I suggest to fix the documentation (patch attached) or to remove that obsolete hack (and drop support for Windows <= NT).

[tjguk]

This code is no longer present in subprocess.py now that bpo-14470 has been applied.

[tjguk]

Reopening because there is in fact a doc issue reamining.

[tjguk]

I can't push from work; the (trivial) doc patch is attached. If no-one gets to it, I'll push from home this evening.

[python-dev]

New changeset 1aac333f320a by Tim Golden in branch 'default':
bpo-16921 Since Win9x is no longer supported, CREATE_NEW_CONSOLE is
http://hg.python.org/cpython/rev/1aac333f320a