Errno checking replaced by concrete classes inherited from OSError

[atykhonov]

BPO	17651
Nosy	@birkenfeld, @vstinner, @asvetlov
Files	issue17651.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-01-29.13:48:10.230>
created_at = <Date 2013-04-07.13:42:24.896>
labels = ['type-feature', 'library']
title = 'Errno checking replaced by concrete classes inherited from OSError'
updated_at = <Date 2018-01-29.13:48:10.230>
user = 'https://bugs.python.org/atykhonov'

bugs.python.org fields:

activity = <Date 2018-01-29.13:48:10.230>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-29.13:48:10.230>
closer = 'asvetlov'
components = ['Library (Lib)']
creation = <Date 2013-04-07.13:42:24.896>
creator = 'atykhonov'
dependencies = []
files = ['29716']
hgrepos = []
issue_num = 17651
keywords = ['patch']
message_count = 5.0
messages = ['186227', '186303', '186565', '186566', '311134']
nosy_count = 4.0
nosy_names = ['georg.brandl', 'vstinner', 'asvetlov', 'atykhonov']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue17651'
versions = ['Python 3.5']

[birkenfeld]

Why not attach this to bpo-16705 directly?

[asvetlov]

I've asked atykhonov for that because we have two sets:

1. Can be done with current exception classes
2. errno values doesn't have concrete OSError inherited exception and we have to make decision: add new exceptions or use errno check.

This issue don't require external changes and can be closed quickly.

[asvetlov]

Looks like the patch is out-of-date and tests doesn't pass.
Would you push updated version?

[atykhonov]

Sure!

[asvetlov]

The issue is outdated and mostly fixed.

Feel free to open a new one if needed.