Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change necessary in platform.py to support IronPython #62194

Closed
sigmavirus24 mannequin opened this issue May 16, 2013 · 3 comments
Closed

Change necessary in platform.py to support IronPython #62194

sigmavirus24 mannequin opened this issue May 16, 2013 · 3 comments
Labels
OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@sigmavirus24
Copy link
Mannequin

sigmavirus24 mannequin commented May 16, 2013

BPO 17994
Nosy @malemburg, @tjguk, @DinoV, @briancurtin, @jdhardy, @zware, @zooba, @sigmavirus24
Superseder
  • bpo-8964: platform._sys_version does not parse correctly IronPython 2.x version
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2018-03-25.23:22:51.397>
    created_at = <Date 2013-05-16.14:24:45.069>
    labels = ['type-bug', 'library', 'OS-windows']
    title = 'Change necessary in platform.py to support IronPython'
    updated_at = <Date 2018-03-25.23:22:51.396>
    user = 'https://github.com/sigmavirus24'

    bugs.python.org fields:

    activity = <Date 2018-03-25.23:22:51.396>
    actor = 'cheryl.sabella'
    assignee = 'none'
    closed = True
    closed_date = <Date 2018-03-25.23:22:51.397>
    closer = 'cheryl.sabella'
    components = ['Library (Lib)', 'Windows']
    creation = <Date 2013-05-16.14:24:45.069>
    creator = 'icordasc'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 17994
    keywords = []
    message_count = 3.0
    messages = ['189383', '218749', '233274']
    nosy_count = 9.0
    nosy_names = ['lemburg', 'tim.golden', 'dino.viehland', 'brian.curtin', 'BreamoreBoy', 'jeff.hardy', 'zach.ware', 'steve.dower', 'icordasc']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '8964'
    type = 'behavior'
    url = 'https://bugs.python.org/issue17994'
    versions = ['3rd party', 'Python 2.7']

    @sigmavirus24
    Copy link
    Mannequin Author

    sigmavirus24 mannequin commented May 16, 2013

    Stemming from a StackOverflow question1 and a conversation with Marc-Andre Lemburg via email, I'm filing this issue without any easy way of confirming it myself.

    It seems that the logic in platform.python_implementation() has been obsoleted by a change made in IronPython. As it is now, it checks that the slice, sys.version[:10], is "IronPython". Seemingly due to a change in IronPython, this no longer is a correct condition for checking that the implementation is IronPython.

    I'm trying to work with the question author on StackOverflow to provide the relevant debugging information to fix this, but it is taking a while to get responses. Without his repr(sys.version) I can't submit a patch with this issue.

    I've also only tagged Python 2.7 since I have no way of knowing if this occurs with Python 3.x or anything earlier.

    @sigmavirus24 sigmavirus24 mannequin added stdlib Python modules in the Lib dir OS-windows labels May 16, 2013
    @briancurtin briancurtin added the type-bug An unexpected behavior, bug, or error label May 16, 2013
    @sigmavirus24
    Copy link
    Mannequin Author

    sigmavirus24 mannequin commented May 18, 2014

    I missed the fact that the user gave me the information from sys.version: https://stackoverflow.com/questions/16545027/ironpython-error-in-url-request?noredirect=1#comment23847257_16545027

    I'll throw together a failing test with this and run it against 2.7, and the 3.x branches.

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jan 1, 2015

    Cpython was changed via bpo-8964 to handle this situation.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    OS-windows stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants