Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write better test for SSLContext.load_verify_locations #66499

Open
pitrou opened this issue Aug 29, 2014 · 2 comments
Open

Write better test for SSLContext.load_verify_locations #66499

pitrou opened this issue Aug 29, 2014 · 2 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@pitrou
Copy link
Member

pitrou commented Aug 29, 2014

BPO 22303
Nosy @pitrou, @giampaolo, @tiran, @alex, @dstufft, @csabella

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2014-08-29.22:24:14.635>
labels = ['type-feature', 'tests']
title = 'Write better test for SSLContext.load_verify_locations'
updated_at = <Date 2019-03-17.23:54:09.779>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2019-03-17.23:54:09.779>
actor = 'cheryl.sabella'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2014-08-29.22:24:14.635>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 22303
keywords = []
message_count = 2.0
messages = ['226092', '338150']
nosy_count = 7.0
nosy_names = ['janssen', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'alex', 'dstufft', 'cheryl.sabella']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue22303'
versions = ['Python 3.5']

@pitrou
Copy link
Member Author

pitrou commented Aug 29, 2014

SSLContext.load_verify_locations() probably takes into account the SSL_CERT_FILE and SSL_CERT_DIR environment variables, when set. This should allow us to write a better test than the existing, minimal one.

@pitrou pitrou added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Aug 29, 2014
@csabella
Copy link
Contributor

bpo-22449 added some tests around these environment variables. Was that enough to satisfy this issue or does more need to be done?

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants