Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 ships an outdated valgrind suppressison file. #68329

Closed
mic-e mannequin opened this issue May 7, 2015 · 3 comments
Closed

Python 3 ships an outdated valgrind suppressison file. #68329

mic-e mannequin opened this issue May 7, 2015 · 3 comments

Comments

@mic-e
Copy link
Mannequin

mic-e mannequin commented May 7, 2015

BPO 24141
Nosy @vstinner, @tiran, @ned-deily
Superseder
  • bpo-24111: Valgrind suppression file should be updated
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2015-05-07.18:39:04.796>
    created_at = <Date 2015-05-07.15:30:10.883>
    labels = []
    title = 'Python 3 ships an outdated valgrind suppressison file.'
    updated_at = <Date 2015-05-07.18:39:04.780>
    user = 'https://bugs.python.org/mic-e'

    bugs.python.org fields:

    activity = <Date 2015-05-07.18:39:04.780>
    actor = 'ned.deily'
    assignee = 'none'
    closed = True
    closed_date = <Date 2015-05-07.18:39:04.796>
    closer = 'ned.deily'
    components = []
    creation = <Date 2015-05-07.15:30:10.883>
    creator = 'mic-e'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 24141
    keywords = []
    message_count = 3.0
    messages = ['242716', '242717', '242722']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'christian.heimes', 'ned.deily', 'mic-e']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '24111'
    type = None
    url = 'https://bugs.python.org/issue24141'
    versions = ['Python 3.4']

    @mic-e
    Copy link
    Mannequin Author

    mic-e mannequin commented May 7, 2015

    The suppression file that is shipped in Misc/valgrind-python.supp of the CPython 3(.x) source tarball only works with CPython 2.

    This was tested on Debian Sid, with Python 3.4.3 and Python 2.7.9, both presumably not compiled with "--valgrind".

    Since Debian does not ship valgrind-python.supp, I downloaded the source tarball for Python 3.4.3, and edited the suppression file (un-commenting the rules for Free and Realloc, as the documentation suggests for when running with a non-valgrind-aware version of CPython).

    The test results are as follows:

    $ uname -a
    Linux mic 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt9-2 (2015-04-13) x86_64 GNU/Linux
    $ lsb_release -a
    No LSB modules are available.
    Distributor ID:	Debian
    Description:	Debian GNU/Linux unstable (sid)
    Release:	unstable
    Codename:	sid
    $ valgrind --version
    valgrind-3.10.1
    $ python3 --version
    Python 3.4.3
    $ python2 --version
    Python 2.7.9
    $ valgrind --tool=memcheck --suppressions=/tmp/Python-3.4.3/Misc/valgrind-python.supp python3 -c 'import sys; print(sys.version)'
    (...) ERROR SUMMARY: 666 errors from 61 contexts (suppressed: 0 from 0)
    $ valgrind --tool=memcheck --suppressions=/tmp/Python-3.4.3/Misc/valgrind-python.supp python2 -c 'import sys; print(sys.version)'
    (...) ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 486 from 28)

    @mic-e mic-e mannequin changed the title Python 3 ships an outdated valgrind suppresison file. Python 3 ships an outdated valgrind suppressison file. May 7, 2015
    @mic-e
    Copy link
    Mannequin Author

    mic-e mannequin commented May 7, 2015

    Note:

    Additionally replacing

    PyObject_Free -> _PyObject_Free

    and

    PyObject_Realloc -> _PyObject_Realloc

    appears to fix the issue.

    @ned-deily
    Copy link
    Member

    Thanks for the report. This problem and solution was just reported recently in bpo-24111.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant