Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_capi to use test.support.script_helper #68586

Closed
bobcatfish mannequin opened this issue Jun 6, 2015 · 4 comments
Closed

Update test_capi to use test.support.script_helper #68586

bobcatfish mannequin opened this issue Jun 6, 2015 · 4 comments
Labels
3.11 only security fixes easy tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@bobcatfish
Copy link
Mannequin

bobcatfish mannequin commented Jun 6, 2015

BPO 24398
Nosy @aidin36, @sobolevn, @iritkatriel
PRs
  • bpo-24398: use run_python_until_end in test_capi #30912
  • Files
  • issue24398.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2015-06-06.18:13:52.309>
    labels = ['easy', 'type-feature', 'tests', '3.11']
    title = 'Update test_capi to use test.support.script_helper'
    updated_at = <Date 2022-01-28.22:44:18.841>
    user = 'https://bugs.python.org/bobcatfish'

    bugs.python.org fields:

    activity = <Date 2022-01-28.22:44:18.841>
    actor = 'sobolevn'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Tests']
    creation = <Date 2015-06-06.18:13:52.309>
    creator = 'bobcatfish'
    dependencies = []
    files = ['45060']
    hgrepos = []
    issue_num = 24398
    keywords = ['patch', 'easy']
    message_count = 4.0
    messages = ['244923', '244931', '278339', '278499']
    nosy_count = 4.0
    nosy_names = ['bobcatfish', 'aidin36', 'sobolevn', 'iritkatriel']
    pr_nums = ['30912']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue24398'
    versions = ['Python 3.11']

    Linked PRs

    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented Jun 6, 2015

    As described in bpo-9517, many test modules do not make use of the helpers in script_helpers.py to invoke the python interpreter in a subprocess. bpo-9517 will be broken down into several smaller issues so we can address smaller change sets.

    This issue is to update test_capi.py to use script_helpers.py.

    @bobcatfish
    Copy link
    Mannequin Author

    bobcatfish mannequin commented Jun 6, 2015

    I can't seem to get test_no_FatalError_infinite_loop to fail - I tried reverting the fix that this was verifying, but the test still passed and no infinite loop to be seen. I'm wondering if this is because I can't reproduce it on a mac.

    @berkerpeksag berkerpeksag added easy tests Tests in the Lib/test dir type-feature A feature request or enhancement labels May 20, 2016
    @aidin36
    Copy link
    Mannequin

    aidin36 mannequin commented Oct 9, 2016

    I am working on this issue.

    @aidin36
    Copy link
    Mannequin

    aidin36 mannequin commented Oct 11, 2016

    I tested the patch locally, on my Gnu/Linux machine, and it seems fine.

    @iritkatriel iritkatriel added the 3.11 only security fixes label Jan 25, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    furkanonder added a commit to furkanonder/cpython that referenced this issue Mar 15, 2023
    miss-islington pushed a commit that referenced this issue Apr 9, 2023
    Co-authored-by: Aidin Gharibnavaz
    
    Automerge-Triggered-By: GH:kumaraditya303
    warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
    Co-authored-by: Aidin Gharibnavaz
    
    Automerge-Triggered-By: GH:kumaraditya303
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes easy tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants