Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage support for CPython 2 #70113

Closed
alecsandrupatrascu mannequin opened this issue Dec 22, 2015 · 5 comments
Closed

Coverage support for CPython 2 #70113

alecsandrupatrascu mannequin opened this issue Dec 22, 2015 · 5 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@alecsandrupatrascu
Copy link
Mannequin

alecsandrupatrascu mannequin commented Dec 22, 2015

BPO 25925
Nosy @zware, @Vgr255
Files
  • coverage-2.7-v01.patch
  • coverage-2.7-v02.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2016-01-20.06:13:25.892>
    created_at = <Date 2015-12-22.14:07:59.998>
    labels = ['type-feature', 'build']
    title = 'Coverage support for CPython 2'
    updated_at = <Date 2016-01-20.06:13:25.891>
    user = 'https://bugs.python.org/alecsandrupatrascu'

    bugs.python.org fields:

    activity = <Date 2016-01-20.06:13:25.891>
    actor = 'zach.ware'
    assignee = 'none'
    closed = True
    closed_date = <Date 2016-01-20.06:13:25.892>
    closer = 'zach.ware'
    components = ['Build']
    creation = <Date 2015-12-22.14:07:59.998>
    creator = 'alecsandru.patrascu'
    dependencies = []
    files = ['41385', '41386']
    hgrepos = []
    issue_num = 25925
    keywords = ['patch']
    message_count = 5.0
    messages = ['256839', '256840', '256841', '258644', '258645']
    nosy_count = 4.0
    nosy_names = ['python-dev', 'zach.ware', 'abarry', 'alecsandru.patrascu']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue25925'
    versions = ['Python 2.7']

    @alecsandrupatrascu
    Copy link
    Mannequin Author

    alecsandrupatrascu mannequin commented Dec 22, 2015

    Hi All,

    This is Alecsandru from Server Scripting Languages Optimization team at Intel Corporation. I would like to submit a patch that adds extended support for coverage, in the same way that it is used in CPython3. Used in conjunction with the regrtests, it provides a broader view of the hot and cold zones in the interpreter.

    Thank you,
    Alecsandru

    @alecsandrupatrascu alecsandrupatrascu mannequin added build The build process and cross-build type-feature A feature request or enhancement labels Dec 22, 2015
    @zware
    Copy link
    Member

    zware commented Dec 22, 2015

    Left a couple of review comments on Rietveld.

    @alecsandrupatrascu
    Copy link
    Mannequin Author

    alecsandrupatrascu mannequin commented Dec 22, 2015

    Thank you for the reviews. I've added a new patch (v02) to correct the issues.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 20, 2016

    New changeset ed7b602a7400 by Zachary Ware in branch '2.7':
    Issue bpo-25925: Backport C coverage reporting Makefile targets
    https://hg.python.org/cpython/rev/ed7b602a7400

    @zware
    Copy link
    Member

    zware commented Jan 20, 2016

    Committed (with a couple minor tweaks), thanks for the patch!

    @zware zware closed this as completed Jan 20, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant