Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions raised in pstats add (repl) #71428

Closed
llllllllll mannequin opened this issue Jun 6, 2016 · 4 comments
Closed

Catch exceptions raised in pstats add (repl) #71428

llllllllll mannequin opened this issue Jun 6, 2016 · 4 comments
Assignees
Labels
type-feature A feature request or enhancement

Comments

@llllllllll
Copy link
Mannequin

llllllllll mannequin commented Jun 6, 2016

BPO 27241
Nosy @birkenfeld, @skrah, @llllllllll
Files
  • catch-pstats-add.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/skrah'
    closed_at = <Date 2016-08-02.20:35:42.767>
    created_at = <Date 2016-06-06.17:46:56.997>
    labels = ['type-feature']
    title = 'Catch exceptions raised in pstats add (repl)'
    updated_at = <Date 2016-08-02.20:35:42.766>
    user = 'https://github.com/llllllllll'

    bugs.python.org fields:

    activity = <Date 2016-08-02.20:35:42.766>
    actor = 'skrah'
    assignee = 'skrah'
    closed = True
    closed_date = <Date 2016-08-02.20:35:42.767>
    closer = 'skrah'
    components = ['Demos and Tools']
    creation = <Date 2016-06-06.17:46:56.997>
    creator = 'llllllllll'
    dependencies = []
    files = ['43262']
    hgrepos = []
    issue_num = 27241
    keywords = ['patch']
    message_count = 4.0
    messages = ['267542', '271840', '271848', '271849']
    nosy_count = 4.0
    nosy_names = ['georg.brandl', 'skrah', 'python-dev', 'llllllllll']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue27241'
    versions = ['Python 3.5', 'Python 3.6']

    @llllllllll
    Copy link
    Mannequin Author

    llllllllll mannequin commented Jun 6, 2016

    I was trying to add a file and accidently mistyped the name which crashed the repl session. I think it would be nicer to report the failure but bring me back to the prompt so I can decide what I would like to do.

    This patch catches any IOErrors that can be raised when adding a file in the repl, reports it to the user, and then returns them to the repl.

    @llllllllll llllllllll mannequin added the type-feature A feature request or enhancement label Jun 6, 2016
    @llllllllll
    Copy link
    Mannequin Author

    llllllllll mannequin commented Aug 2, 2016

    bump

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 2, 2016

    New changeset d9e25fe35f46 by Stefan Krah in branch '3.5':
    Issue bpo-27241: Catch exception when running pstats as main.
    https://hg.python.org/cpython/rev/d9e25fe35f46

    @skrah
    Copy link
    Mannequin

    skrah mannequin commented Aug 2, 2016

    Yes, I agree this is nicer. Thanks for the patch.

    @skrah skrah mannequin closed this as completed Aug 2, 2016
    @skrah skrah mannequin self-assigned this Aug 2, 2016
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants