Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes support in os.fwalk() #72868

Closed
serhiy-storchaka opened this issue Nov 13, 2016 · 4 comments
Closed

Bytes support in os.fwalk() #72868

serhiy-storchaka opened this issue Nov 13, 2016 · 4 comments
Labels
3.7 stdlib type-feature

Comments

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 13, 2016

BPO 28682
Nosy @loewis, @vstinner, @larryhastings, @serhiy-storchaka, @ztane
PRs
  • #489
  • Files
  • fwalk-bytes.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-03-08.15:24:23.746>
    created_at = <Date 2016-11-13.09:24:10.436>
    labels = ['3.7', 'type-feature', 'library']
    title = 'Bytes support in os.fwalk()'
    updated_at = <Date 2017-03-24.22:43:36.673>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2017-03-24.22:43:36.673>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-03-08.15:24:23.746>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2016-11-13.09:24:10.436>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['45470']
    hgrepos = []
    issue_num = 28682
    keywords = ['patch']
    message_count = 4.0
    messages = ['280690', '281760', '281819', '290278']
    nosy_count = 7.0
    nosy_names = ['loewis', 'vstinner', 'larry', 'zmedico', 'neologix', 'serhiy.storchaka', 'ztane']
    pr_nums = ['489']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue28682'
    versions = ['Python 3.7']

    @serhiy-storchaka
    Copy link
    Member Author

    @serhiy-storchaka serhiy-storchaka commented Nov 13, 2016

    os.walk() supports string and bytes paths, but os.fwalk() always supported only string paths. Proposed patch adds support of bytes paths in os.fwalk().

    @serhiy-storchaka serhiy-storchaka added 3.7 stdlib type-feature labels Nov 13, 2016
    @ztane
    Copy link
    Mannequin

    @ztane ztane mannequin commented Nov 26, 2016

    shouldn't this get in sooner, as the 3.5.2 documentation says that it behaves exactly like os.walk, with some additions, none of which says "bytes paths are not supported". This looks like a bug to me.

    @serhiy-storchaka
    Copy link
    Member Author

    @serhiy-storchaka serhiy-storchaka commented Nov 27, 2016

    Bytes path support is os.walk() is not documented. Actual behavior of os.fwalk() doesn't contradict the documentation.

    @serhiy-storchaka
    Copy link
    Member Author

    @serhiy-storchaka serhiy-storchaka commented Mar 24, 2017

    New changeset 8f6b344 by Serhiy Storchaka in branch 'master':
    bpo-28682: Added support for bytes paths in os.fwalk(). (#489)
    8f6b344

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 stdlib type-feature
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant