bpo-28682: Added support for bytes paths in os.fwalk(). #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @Haypo, @benjaminp, @larryhastings and @brettcannon to be potential reviewers. |
vstinner
reviewed
Mar 6, 2017
Lib/test/test_os.py
Outdated
| """Tests for os.walk() with bytes.""" | ||
| def setUp(self): | ||
| super().setUp() | ||
| self.stack = contextlib.ExitStack() |
There was a problem hiding this comment.
What is the purpose of self.stack?
There was a problem hiding this comment.
It is not needed. This is just a copy from BytesWalkTests. But in BytesWalkTests it is not needed either. It was used in the past for silencing deprecation warnings about using Windows bytes API.
There was a problem hiding this comment.
If it's not used, please remove it. Remove it also from BytesWalkTests.
There was a problem hiding this comment.
oh sorry, you already did it, thanks :-)
brettcannon
approved these changes
Mar 6, 2017
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Bumps [cachetools](https://github.com/tkem/cachetools) from 4.2.2 to 4.2.4. - [Release notes](https://github.com/tkem/cachetools/releases) - [Changelog](https://github.com/tkem/cachetools/blob/master/CHANGELOG.rst) - [Commits](tkem/cachetools@v4.2.2...v4.2.4) --- updated-dependencies: - dependency-name: cachetools dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.