weird comment out line of code

[zhangyangyu]

BPO	32688
Nosy	@brettcannon, @zhangyangyu
PRs	bpo-32688: Make why the line is commented out clear #5405

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-01-28.14:53:07.597>
created_at = <Date 2018-01-27.16:03:53.462>
labels = ['3.7', 'invalid']
title = 'weird comment out line of code'
updated_at = <Date 2018-01-29.03:52:21.318>
user = 'https://github.com/zhangyangyu'

bugs.python.org fields:

activity = <Date 2018-01-29.03:52:21.318>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2018-01-28.14:53:07.597>
closer = 'xiang.zhang'
components = []
creation = <Date 2018-01-27.16:03:53.462>
creator = 'xiang.zhang'
dependencies = []
files = []
hgrepos = []
issue_num = 32688
keywords = []
message_count = 8.0
messages = ['310866', '310868', '310877', '310950', '310990', '311044', '311045', '311050']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'xiang.zhang']
pr_nums = ['5405']
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue32688'
versions = ['Python 3.7']

[zhangyangyu]

I find one line[1] is weirdly commented out. But I don't think profile here is any different with trace. In 2.7, this line is not commented out and the change happens in b94767f, fixing clang warnings.

[zhangyangyu]

Sorry, forget links, it's https://github.com/python/cpython/blob/master/Python/ceval.c#L3528 , and the commit is b94767f.

[brettcannon]

I don't remember why that line was commented out to make the analyzer happy.

[zhangyangyu]

Ahh, I figure out that the line is useless and can't affect any logic then. So the analyzer is right! Sorry for the bother Brett.

[brettcannon]

We should probably delete the line regardless so no one else gets thrown by this (or at least leave a comment).

[zhangyangyu]

New changeset 997478e by Xiang Zhang in branch 'master':
bpo-32688: Make why the line is commented out clear (GH-5405)
997478e

[zhangyangyu]

Done.

[brettcannon]

Thanks!

On Sun, Jan 28, 2018, 19:32 Xiang Zhang, <report@bugs.python.org> wrote:

Xiang Zhang <angwerzx@126.com> added the comment:

Done.

----------
versions: -Python 3.6

---

Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue32688\>

---