-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x #77795
Comments
http://buildbot.python.org/all/#/builders/80/builds/244
Maybe it's related to this recent change: commit 4e29f56
The two missing symbols are defined by: #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03070000
PyAPI_FUNC(PyObject *) PyImport_GetModule(PyObject *name);
#endif and #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03070000
PyAPI_DATA(int) Py_UTF8Mode;
#endif They are not part of the stable ABI. |
My bad, I didn't test that change on Windows myself, and CI seems was broken at that moment. But I have no ideas why the build is failed. These names are part of stable ABI since version 3.7. I don't see any difference between PyImport_GetModule and say PyInterpreterState_GetID. |
It succeeds after removing directories amd64 and obj in PCbuild. Seems they are left from old builds and the clean up script did nor remove them. This may be a cause of other weird bugs on Windows. |
I guess that means there is an invalid date comparison going on to detect when the file has changed. This file doesn't change often, so it's easy to miss :) All the critical builds should forcibly rebuild it, so this isn't urgent, but I'll take a look next time I get a chance to work on the build files. |
If "PCbuild\build.bat -p x64" builds Python, "PCbuild\clean.bat -p x64" removes all files in PCbuild\amd64 but python3stub.exp and python3stub.lib. |
It's more than a *bit* urgent since it is causing one of the 3.7 stable buildbots to fail to build and not run tests and we normally would not allow a release with stable buildbot failures. |
(for example, http://buildbot.python.org/all/#/builders/133/builds/251 ) |
Okay, I'll take a look now. |
Steve: just a minute ago, zware out the win8.1 bot's repo and restarted a 3.7 build. |
er, "cleaned out" |
That Windows8.1 buildbot sure keeps busy with all those builders assigned to it :) Those refleaks builds take a *long* time! http://buildbot.python.org/all/#/workers/11 But I see at least one builder has made it through successfully and no longer fails in this manner: http://buildbot.python.org/all/#/builders/12/builds/892 So I think we can close this now. Thanks, everyone. |
I think the underlying issue is not fixed still. Adding new symbols in python3.def will break this buildbot (as well as users worktrees) again. |
Considering we didn't change anything in the sources, I wouldn't expect it to be fixed. It doesn't have to block 3.7 if Ned's okay with it, but I'd like to keep this open and fix the build scripts. |
Sorry, I *did* close the issue prematurely; thanks for noticing! |
Steve - PR 7165 appears to have caused a buildbot failure: |
Thanks! I guess we were getting lucky in the past, as that error could have shown up for any number of reasons... |
I *believe* this change will prevent the issue in the future, so marking this as fixed. But I wasn't able to reproduce it locally, so there may be something funny about either the file system or the version of MSBuild on the buildbots that caused it to not rebuild properly. In any case, my change causes it to rebuild based on contents rather than timestamp, so it should be more reliable. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: