Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdb.Bdb.set_trace: should set f_trace_lines = True #80675

Closed
blueyed mannequin opened this issue Mar 31, 2019 · 5 comments
Closed

bdb.Bdb.set_trace: should set f_trace_lines = True #80675

blueyed mannequin opened this issue Mar 31, 2019 · 5 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@blueyed
Copy link
Mannequin

blueyed mannequin commented Mar 31, 2019

BPO 36494
Nosy @blueyed, @iritkatriel
PRs
  • bpo-36494: bdb.Bdb.set_trace: set frame.f_trace_lines = True #12640
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2019-03-31.14:28:51.712>
    labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
    title = 'bdb.Bdb.set_trace: should set f_trace_lines = True'
    updated_at = <Date 2021-05-21.21:16:24.081>
    user = 'https://github.com/blueyed'

    bugs.python.org fields:

    activity = <Date 2021-05-21.21:16:24.081>
    actor = 'iritkatriel'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2019-03-31.14:28:51.712>
    creator = 'blueyed'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36494
    keywords = ['patch']
    message_count = 2.0
    messages = ['339259', '394158']
    nosy_count = 2.0
    nosy_names = ['blueyed', 'iritkatriel']
    pr_nums = ['12640']
    priority = 'normal'
    resolution = None
    stage = 'test needed'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36494'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Linked PRs

    @blueyed
    Copy link
    Mannequin Author

    blueyed mannequin commented Mar 31, 2019

    bdb.Bdb.set_trace should set "f_trace_lines = True" on frames explicitly.

    Otherwise they might be skipped if something else has set it to False already, e.g. via a suggested change for coverage.py to set this for performance reasons (nedbat/coveragepy#791).

    @blueyed blueyed mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes stdlib Python modules in the Lib dir labels Mar 31, 2019
    @blueyed blueyed mannequin changed the title bdb: should set f_trace_lines = True bdb.Bdb.set_trace: should set f_trace_lines = True Mar 31, 2019
    @blueyed blueyed mannequin added the type-bug An unexpected behavior, bug, or error label Mar 31, 2019
    @iritkatriel iritkatriel added 3.10 only security fixes 3.11 only security fixes and removed 3.7 (EOL) end of life 3.8 only security fixes labels May 21, 2021
    @iritkatriel
    Copy link
    Member

    The patch needs a test.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @nedbat
    Copy link
    Member

    nedbat commented Jun 13, 2022

    Coverage.py now sets f_trace_lines=0 when it doesn't want to trace, and I've started getting bug reports that this breaks tests using pdb: nedbat/coveragepy#1402. Can we move this forward?

    @iritkatriel
    Copy link
    Member

    @nedbat, I don't think @blueyed plans to finish this. Would you like to take over?

    @gaogaotiantian
    Copy link
    Member

    Fixed.

    aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants