Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate method definition in Lib/test/test_genericclass.py #80860

Closed
xdegaye mannequin opened this issue Apr 20, 2019 · 6 comments
Closed

duplicate method definition in Lib/test/test_genericclass.py #80860

xdegaye mannequin opened this issue Apr 20, 2019 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@xdegaye
Copy link
Mannequin

xdegaye mannequin commented Apr 20, 2019

BPO 36679
Nosy @xdegaye, @zooba, @ilevkivskyi
PRs
  • bpo-36679: rename duplicate test_class_getitem function #12892
  • [3.7] bpo-36679: Rename duplicate test_class_getitem function (GH-12892) #12978
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2019-04-27.01:23:23.751>
    created_at = <Date 2019-04-20.15:59:38.702>
    labels = ['3.7', '3.8', 'type-bug', 'library']
    title = 'duplicate method definition in Lib/test/test_genericclass.py'
    updated_at = <Date 2019-04-27.01:23:23.750>
    user = 'https://github.com/xdegaye'

    bugs.python.org fields:

    activity = <Date 2019-04-27.01:23:23.750>
    actor = 'levkivskyi'
    assignee = 'none'
    closed = True
    closed_date = <Date 2019-04-27.01:23:23.751>
    closer = 'levkivskyi'
    components = ['Library (Lib)']
    creation = <Date 2019-04-20.15:59:38.702>
    creator = 'xdegaye'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 36679
    keywords = ['patch']
    message_count = 6.0
    messages = ['340579', '340674', '340938', '340939', '340955', '340956']
    nosy_count = 3.0
    nosy_names = ['xdegaye', 'steve.dower', 'levkivskyi']
    pr_nums = ['12892', '12978']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue36679'
    versions = ['Python 3.7', 'Python 3.8']

    @xdegaye
    Copy link
    Mannequin Author

    xdegaye mannequin commented Apr 20, 2019

    As reported in bpo-16079, the following method is a duplicate:

    Lib/test/test_genericclass.py:161 TestClassGetitem.test_class_getitem

    @xdegaye xdegaye mannequin added 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Apr 20, 2019
    @zooba
    Copy link
    Member

    zooba commented Apr 22, 2019

    New changeset d437012 by Steve Dower (Windson yang) in branch 'master':
    bpo-36679: Rename duplicate test_class_getitem function (GH-12892)
    d437012

    @zooba zooba closed this as completed Apr 22, 2019
    @xdegaye xdegaye mannequin added the 3.7 (EOL) end of life label Apr 25, 2019
    @xdegaye xdegaye mannequin reopened this Apr 25, 2019
    @ilevkivskyi
    Copy link
    Member

    Thanks for fixing this!

    @ilevkivskyi
    Copy link
    Member

    Oh, sorry, didn't notice the backport is missing!

    @ilevkivskyi ilevkivskyi reopened this Apr 26, 2019
    @ilevkivskyi
    Copy link
    Member

    New changeset d111490 by Ivan Levkivskyi in branch '3.7':
    [3.7] bpo-36679: Rename duplicate test_class_getitem function (GH-12892) (GH-12978)
    d111490

    @ilevkivskyi
    Copy link
    Member

    OK, backported the fix to 3.7.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants