Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36679: rename duplicate test_class_getitem function #12892

Merged
merged 1 commit into from
Apr 22, 2019
Merged

bpo-36679: rename duplicate test_class_getitem function #12892

merged 1 commit into from
Apr 22, 2019

Conversation

Windsooon
Copy link
Contributor

@Windsooon Windsooon commented Apr 21, 2019 •
edited
Loading

rename duplicate test_class_getitem to test_class_getitem_format, I'm not sure should I add news for it?

https://bugs.python.org/issue36679

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 21, 2019
@zooba zooba merged commit d437012 into python:master Apr 22, 2019
ilevkivskyi pushed a commit to ilevkivskyi/cpython that referenced this pull request Apr 27, 2019
@Windsooon
[3.7] bpo-36679: Rename duplicate test_class_getitem function (python…
10711e1 
…GH-12892)

(cherry picked from commit d437012)

Co-authored-by: Windson yang <wiwindson@outlook.com>
@ilevkivskyi
Copy link
Member

#12978 is the backport to 3.7

ilevkivskyi added a commit that referenced this pull request Apr 27, 2019
@ilevkivskyi @Windsooon
[3.7] bpo-36679: Rename duplicate test_class_getitem function (GH-12892…
d111490 
…) (GH-12978)

(cherry picked from commit d437012)

Co-authored-by: Windson yang <wiwindson@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Windsooon @ilevkivskyi @zooba @the-knights-who-say-ni @bedevere-bot