Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build macOS version with thin lto option #88889

Closed
corona10 opened this issue Jul 23, 2021 · 6 comments
Closed

Build macOS version with thin lto option #88889

corona10 opened this issue Jul 23, 2021 · 6 comments
Assignees
Labels
3.11 only security fixes build The build process and cross-build OS-mac type-feature A feature request or enhancement

Comments

@corona10
Copy link
Member

BPO 44726
Nosy @ronaldoussoren, @ned-deily, @corona10
PRs
  • bpo-44726: Update macOS build-installer script to use thin-lto option #27307
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ned-deily'
    closed_at = None
    created_at = <Date 2021-07-23.14:39:15.401>
    labels = ['OS-mac', 'type-feature', 'build', '3.11']
    title = 'Build macOS version with thin lto option'
    updated_at = <Date 2021-07-23.15:23:29.470>
    user = 'https://github.com/corona10'

    bugs.python.org fields:

    activity = <Date 2021-07-23.15:23:29.470>
    actor = 'corona10'
    assignee = 'ned.deily'
    closed = False
    closed_date = None
    closer = None
    components = ['Build', 'macOS']
    creation = <Date 2021-07-23.14:39:15.401>
    creator = 'corona10'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44726
    keywords = ['patch']
    message_count = 5.0
    messages = ['398058', '398060', '398062', '398064', '398066']
    nosy_count = 3.0
    nosy_names = ['ronaldoussoren', 'ned.deily', 'corona10']
    pr_nums = ['27307']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue44726'
    versions = ['Python 3.11']

    @corona10
    Copy link
    Member Author

    Since the thin-lto option is available for macOS distribution.
    We can consider using the thin-lto option for the next macOS Python distribution?

    @corona10 corona10 added 3.11 only security fixes build The build process and cross-build OS-mac type-feature A feature request or enhancement labels Jul 23, 2021
    @corona10
    Copy link
    Member Author

    see bpo-44340

    @corona10
    Copy link
    Member Author

    However, to use thin-lto, build-installer.py should use clang compiler.
    We need to check this issue.

    @ned-deily
    Copy link
    Member

    Thanks for the suggestion. I will do some testing and, if warranted, make the necessary changes.

    @corona10
    Copy link
    Member Author

    Thanks for the suggestion. I will do some testing and, if warranted, make the necessary changes.

    Thanks Ned!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @corona10
    Copy link
    Member Author

    corona10 commented Oct 2, 2022

    This PR solved the issue: #96766

    @corona10 corona10 closed this as completed Oct 2, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes build The build process and cross-build OS-mac type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants