Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting statements in docs about default support for asyncio subprocesses on Windows #90054

Closed
rob4226 mannequin opened this issue Nov 24, 2021 · 6 comments
Closed
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@rob4226
Copy link
Mannequin

rob4226 mannequin commented Nov 24, 2021

BPO 45896
Nosy @asvetlov, @1st1, @miss-islington, @rob4226
PRs
  • bpo-45896: Fix docs default asyncio event loop on Windows #29857
  • [3.10] bpo-45896: Fix docs default asyncio event loop on Windows (GH-29857) #29877
  • [3.9] bpo-45896: Fix docs default asyncio event loop on Windows (GH-29857) #29878
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-12-01.15:44:36.733>
    created_at = <Date 2021-11-24.22:15:22.430>
    labels = ['3.11', 'type-bug', '3.9', '3.10', 'docs']
    title = 'Conflicting statements in docs about default support for asyncio subprocesses on Windows'
    updated_at = <Date 2021-12-01.15:44:36.733>
    user = 'https://github.com/rob4226'

    bugs.python.org fields:

    activity = <Date 2021-12-01.15:44:36.733>
    actor = 'asvetlov'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2021-12-01.15:44:36.733>
    closer = 'asvetlov'
    components = ['Documentation']
    creation = <Date 2021-11-24.22:15:22.430>
    creator = 'Rob4226'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45896
    keywords = ['patch']
    message_count = 6.0
    messages = ['406967', '406975', '406976', '407449', '407460', '407462']
    nosy_count = 5.0
    nosy_names = ['asvetlov', 'docs@python', 'yselivanov', 'miss-islington', 'Rob4226']
    pr_nums = ['29857', '29877', '29878']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45896'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @rob4226
    Copy link
    Mannequin Author

    rob4226 mannequin commented Nov 24, 2021

    Hi,

    In the docs for the asyncio event loop, it has a note on page:
    https://docs.python.org/3/library/asyncio-eventloop.html#running-subprocesses

    "Note The default asyncio event loop on Windows does not support subprocesses. See Subprocess Support on Windows for details."

    Then following the link in that note to:
    https://docs.python.org/3/library/asyncio-platforms.html#subprocess-support-on-windows
    Says:
    "On Windows, the default event loop ProactorEventLoop supports subprocesses, whereas SelectorEventLoop does not."

    So the issue is, there are conflicting statements about default support for asyncio subprocesses on Windows. It seems the first statement listed above, is wrong or outdated since the default event loop on Windows is the ProactorEventLoop which does support subprocesses.

    Thank you!

    @rob4226 rob4226 mannequin added the 3.10 only security fixes label Nov 24, 2021
    @rob4226 rob4226 mannequin assigned docspython Nov 24, 2021
    @rob4226 rob4226 mannequin added docs Documentation in the Doc dir 3.10 only security fixes labels Nov 24, 2021
    @rob4226 rob4226 mannequin assigned docspython Nov 24, 2021
    @rob4226 rob4226 mannequin added the docs Documentation in the Doc dir label Nov 24, 2021
    @AlexWaygood AlexWaygood added 3.9 only security fixes 3.11 only security fixes type-bug An unexpected behavior, bug, or error labels Nov 25, 2021
    @asvetlov
    Copy link
    Contributor

    You are correct, the first statement is outdated.

    Please feel free to make a pull request.

    @rob4226
    Copy link
    Mannequin Author

    rob4226 mannequin commented Nov 25, 2021

    Ok will do. Thanks for confirming.

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Dec 1, 2021

    New changeset f27bef3 by Rob in branch 'main':
    bpo-45896: Fix docs default asyncio event loop on Windows (GH-29857)
    f27bef3

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Dec 1, 2021

    New changeset 4203a5d by Miss Islington (bot) in branch '3.9':
    bpo-45896: Fix docs default asyncio event loop on Windows (GH-29857) (GH-29878)
    4203a5d

    @asvetlov
    Copy link
    Contributor

    asvetlov commented Dec 1, 2021

    New changeset e99c5e0 by Miss Islington (bot) in branch '3.10':
    bpo-45896: Fix docs default asyncio event loop on Windows (GH-29857) (GH-29877)
    e99c5e0

    @asvetlov asvetlov closed this as completed Dec 1, 2021
    @asvetlov asvetlov closed this as completed Dec 1, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants