-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR check "Check if generated files are up to date" failing intermittently #91302
Comments
The "Check if generated files are up to date" GitHub check for PRs has been failing recently. It may also impact local usage of "make regen-all". Example: https://github.com/python/cpython/runs/5719012664 This may be related to #76242. |
There's probably something racy with make. See: https://github.com/python/cpython/runs/5712538599?check_suite_focus=true#step:10:1147 |
Looks like that fixed it, per #32134. |
Looks like this is still an intermittent problem:
Per Mark Shannon (on discord): The "Check if generated files are up to date" is still failing consistently. It looks like the makefile is missing a dependency on the ./Programs/_freeze_module for targets that require /Programs/_freeze_module |
The problem is likely a recursive make call "$(MAKE)" in combination with parallel execution. As far as I understand it, GNU make cannot track dependencies properly, which can lead to partial or invalid dependency graphs. One make process can modify a file while another uses the file. The permission error or ETXTBSY error are manifestation of one process creating an executable while another process is attempting to execve() it. The paper https://accu.org/journals/overload/14/71/miller_2004/ explains the issues with recursion in great detail. |
I re-ran jobs that had failed before I merged that #76387. Several passed, but the following are still failing:
Back to the drawing board... |
Brandt pointed out this is consistently reproducible locally: make clean regen-all -j I'll get this sorted out today. |
I'll keep an eye on PRs for the next day or so. |
Looks like #76399 worked. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: