-
-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tools/pynche #91551
Comments
I see this tool as a neat way to find some pretty named color. Maybe it should be moved to A patch to make a program runnable: diff --git a/Tools/pynche/PyncheWidget.py b/Tools/pynche/PyncheWidget.py
index ea456e577e..e73d48f16a 100644
--- a/Tools/pynche/PyncheWidget.py
+++ b/Tools/pynche/PyncheWidget.py
@@ -37,7 +37,7 @@ def __init__(self, version, switchboard, master=None, extrapath=[]):
# Is there already a default root for Tk, say because we're
# running under Guido's IDE? :-) Two conditions say no, either the
# _default_root is None or it is unset.
- tkroot = getattr(tkinter, '_default_root', None)
+ tkroot = getattr(sys.modules['tkinter'], '_default_root', None)
if not tkroot:
tkroot = Tk(className='Pynche')
self.__tkroot = tkroot I runned it as follows: PCbuild\amd64\python Tools\pynche\Main.py -d Tools\pynche\X\rgb.txt |
JFY: I'm trying it out in https://github.com/python/cpython/compare/main...arhadthedev:dustoff-pynche?expand=1. |
@arhadthedev if you're interested in maintaining it, probably better to just start a new repo. That way there's one less thing to keep around in Python itself. |
I wouldn't be opposed to either option. I can think of a couple of choices:
If I was to do it, I'd prefer GitLab, but GitHub is just fine too. Preferences? |
I see no reason to keep this buried within the CPython repo.. Delete it here. Let whoever wants to maintain it put it up in a new repo anywhere (and presumably on pypi - their choice). LOL SunView! |
Okay, I will copy the files out into my own repo (likely on GitLab though), and will happily add any contributors who want to help out. I'm going to mark this PR as draft until then, then will undraft it and merge. Thanks! |
You may know it already but in case not, here are some magic git commands to copy files into a new repo, preserving history: |
Contributions and collaborations welcome: https://gitlab.com/warsaw/pynche |
Screenshots in Python 3.10 with @arhadthedev patch. Main window: About window: Before this tool has been removed, I didn't know it! It's interesting that it still works (with a oneliner patch)! I didn't know SunOS SunView neither! Tool added to Python in 1998 (Python v1.5.1) with commit 516f189:
|
@larryhastings reminded me of this ancient program. It's way past time to remove this directory from
Tools/
. I have no way to test it and zero interest in supporting it. I don't even know the last time anybody mentioned it. I don't even have enough interest to keep it alive in a separate repository.Fun historical fact: I wrote the original version of this color editor for SunView.
The text was updated successfully, but these errors were encountered: